Fix ArrowFlightReadExec result streaming #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabotechs
commented
Aug 5, 2025
Comment on lines
-128
to
-129
| // concurrenly build streams for each stage | ||
| // TODO: tokio spawn instead here? |
Collaborator
Author
There was a problem hiding this comment.
I think this is fine. As this is pure IO work, I think it's fair to not spawn it and just join it in a single thread
Collaborator
There was a problem hiding this comment.
That was my thought too, but I left the comment so that we'd get an additional perspective. Ty 👍
NGA-TRAN
approved these changes
Aug 6, 2025
Collaborator
NGA-TRAN
left a comment
NGA-TRAN
left a comment
There was a problem hiding this comment.
LGTM. Create FlightServiceClient to get a stream of data back including decoded error
robtandy
approved these changes
Aug 6, 2025
Base automatically changed from
gabrielmusat/port_and_refactor_execution_code_suggestions
to
main
August 6, 2025 16:38
# Conflicts: # src/plan/arrow_flight_read.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wires up the FligthServiceClient with the
ArrowFlightReadExecnode so that actual gRPC flight calls are issued to theArrowFlightEndpoint.It uses the gRPC generated
FlightServiceClientinstead of theFlightClientin order to used theBoxCloneSyncChannelcreated by theChannelManager