-
Notifications
You must be signed in to change notification settings - Fork 14
Split ArrowFlightReadExec node placement for distributed planning #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gabotechs
merged 7 commits into
main
from
gabrielmusat/injectabe-arrow-flight-read-execs
Aug 6, 2025
Merged
Split ArrowFlightReadExec node placement for distributed planning #79
gabotechs
merged 7 commits into
main
from
gabrielmusat/injectabe-arrow-flight-read-execs
Aug 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8cd19c2 to
8067b44
Compare
b1c72c3 to
c1f6d4c
Compare
gabotechs
commented
Aug 6, 2025
Comment on lines
-444
to
-457
| ┌───── Stage 2 Task: partitions: 0..3,unassigned] | ||
| │partitions [out:4 <-- in:4 ] RepartitionExec: partitioning=Hash([RainTomorrow@0], 4), input_partitions=4 | ||
| │partitions [out:4 <-- in:4 ] AggregateExec: mode=Partial, gby=[RainTomorrow@1 as RainTomorrow], aggr=[avg(weather.MinTemp)] | ||
| │partitions [out:4 <-- in:4 ] CoalesceBatchesExec: target_batch_size=8192 | ||
| │partitions [out:4 <-- in:4 ] FilterExec: RainToday@1 = yes, projection=[MinTemp@0, RainTomorrow@2] | ||
| │partitions [out:4 ] ArrowFlightReadExec: Stage 1 | ||
| │ | ||
| └────────────────────────────────────────────────── | ||
| ┌───── Stage 1 Task: partitions: 0..3,unassigned] | ||
| │partitions [out:4 <-- in:1 ] RepartitionExec: partitioning=RoundRobinBatch(4), input_partitions=1 | ||
| │partitions [out:1 ] DataSourceExec: file_groups={1 group: [[/testdata/weather.parquet]]}, projection=[MinTemp, RainToday, RainTomorrow], file_type=parquet, predicate=RainToday@1 = yes, pruning_predicate=RainToday_null_count@2 != row_count@3 AND RainToday_min@0 <= yes AND yes <= RainToday_max@1, required_guarantees=[RainToday in (yes)] | ||
| │ | ||
| │ | ||
| └────────────────────────────────────────────────── |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the depth here was wrong in the previous implementation, the new depth looks correct
1. ArrowFlightReadExec assignation 2. Stage creation
c8d1e7f to
7b7c405
Compare
robtandy
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the distributed planning in two steps:
ArrowFlightReadExecnodes in "pending" mode through the plan. These will serve as placeholders, just puts a logical network boundary in the appropriate places so that the second step can build stages out of that.ArrowFlightReadExecnodes in "pending" mode, puts them in "ready" mode and wraps the plan in stages.For example:
Given the following query:
and the following plan
ArrowFlightReadExecnodesThe benefit is that now users are able to skip the first step, and choose to place the
ArrowFlightReadExecnodes wherever they want, and just reuse the 2 step to convert their plans into stages.