-
Notifications
You must be signed in to change notification settings - Fork 14
add doc comment for execution stage struct #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -15,10 +15,64 @@ use crate::task::ExecutionTask; | |||||
| use crate::ChannelManager; | ||||||
|
|
||||||
| /// A unit of isolation for a portion of a physical execution plan | ||||||
| /// that can be executed independently. | ||||||
| /// that can be executed independently and across a network boundary. | ||||||
| /// It implements [`ExecutionPlan`] and can be executed to produce a | ||||||
| /// stream of record batches. | ||||||
| /// | ||||||
| /// see https://howqueryengineswork.com/13-distributed-query.html | ||||||
| /// An ExecutionTask is a finer grained unit of work compared to an ExecutionStage. | ||||||
| /// One ExecutionStage will create one or more ExecutionTasks | ||||||
| /// | ||||||
| /// When an [`ExecutionStage`] is execute()'d if will execute its plan and return a stream | ||||||
| /// of record batches. | ||||||
| /// | ||||||
| /// If the stage has input stages, then it those input stages will be executed on remote resources | ||||||
| /// and will be provided the remainder of the stage tree. | ||||||
| /// | ||||||
| /// For example if our stage tree looks like this: | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The sentence does not sound finish |
||||||
| /// | ||||||
| /// ```text | ||||||
| /// ┌─────────┐ | ||||||
| /// │ stage 1 │ | ||||||
| /// └───┬─────┘ | ||||||
| /// │ | ||||||
| /// ┌──────┴────────┐ | ||||||
| /// ┌────┴────┐ ┌────┴────┐ | ||||||
| /// │ stage 2 │ │ stage 3 │ | ||||||
| /// └────┬────┘ └─────────┘ | ||||||
| /// │ | ||||||
| /// ┌──────┴────────┐ | ||||||
| /// ┌────┴────┐ ┌────┴────┐ | ||||||
| /// │ stage 4 │ │ Stage 5 │ | ||||||
| /// └─────────┘ └─────────┘ | ||||||
| /// | ||||||
| /// ``` | ||||||
| /// | ||||||
| /// Then executing Stage 1 will run its plan locally. Stage 1 has two inputs, Stage 2 and Stage 3. We | ||||||
| /// know these will execute on remote resources. As such the plan for Stage 1 must contain an | ||||||
| /// [`ArrowFlightReadExec`] node that will read the results of Stage 2 and Stage 3 and coalese the | ||||||
| /// results. | ||||||
| /// | ||||||
| /// When Stage 1's [`ArrowFlightReadExec`] node is executed, it makes an ArrowFlightRequest to the | ||||||
| /// host assigned in the Stage. It provides the following Stage tree serialilzed in the body of the | ||||||
| /// Arrow Flight Ticket: | ||||||
| /// | ||||||
| /// ```text | ||||||
| /// ┌─────────┐ | ||||||
| /// │ Stage 2 │ | ||||||
| /// └────┬────┘ | ||||||
| /// │ | ||||||
| /// ┌──────┴────────┐ | ||||||
| /// ┌────┴────┐ ┌────┴────┐ | ||||||
| /// │ Stage 4 │ │ Stage 5 │ | ||||||
| /// └─────────┘ └─────────┘ | ||||||
| /// | ||||||
| /// ``` | ||||||
| /// | ||||||
| /// The receiving ArrowFlightEndpoint will then execute Stage 2 and will repeat this process. | ||||||
| /// | ||||||
| /// When Stage 4 4 is executed, it has no input tasks, so it is assumed that the plan included in that | ||||||
|
||||||
| /// When Stage 4 4 is executed, it has no input tasks, so it is assumed that the plan included in that | |
| /// When Stage 4 is executed, it has no input tasks, so it is assumed that the plan included in that |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.