Extend SessionBuilder trait to operate on SessionState and SessionContext #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While integrating TPCH benchmarks with the codebase, I realize that the
SessionBuildertrait needs to allow more flexibility to users for configuring their session.In order to understand what's needed, it's convenient to know how users create DataFusion sessions:
SessionStateBuilder, and start building their session. ✅ we allow configuring this.build()and get aSessionState, which can be further configured. ❌ we don't allow configuring thisSessionContextout of the state, which can be further configured. ❌ we don't allow configuring thisThis PR adds two more methods to the
SessionBuildertrait, and it now looks like this:This allows the user to configure:
SessionStateBuilder✅SessionState✅SessionContext✅This unlocks wiring up the
datafusion-distributedproject with the TPCH benchmarks from #73