feat: add composite primary key support#9
Open
PierreZ wants to merge 1 commit intodatafusion-contrib:mainfrom
Open
feat: add composite primary key support#9PierreZ wants to merge 1 commit intodatafusion-contrib:mainfrom
PierreZ wants to merge 1 commit intodatafusion-contrib:mainfrom
Conversation
Replace the single-column `__row_id__` design with composite primary key support. All columns in `Index::index_schema()` are now treated as the composite primary key, enabling multi-column key lookups. Key changes: - `create_index_schema()` accepts `impl IntoIterator<Item = Field>` - `create_plan_properties_for_pk_scan()` replaces row_id-specific variant - AND joins operate on all PK columns with Projection to deduplicate - OR dedup uses `GROUP BY` on all PK columns - Return proper errors instead of silent fallbacks in join column lookup - Use full Field equality in `project_to_pk_schema()` - Align README and rustdoc with composite PK terminology - Fix unresolved `UnionExec` rustdoc links - Suppress false-positive dead_code warnings in shared test helpers - Add composite PK integration tests with multi-tenant example Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the single-column
__row_id__design with composite primary key support. All columns inIndex::index_schema()are now treated as the composite primary key, enabling multi-column key lookups.Key changes:
create_index_schema()acceptsimpl IntoIterator<Item = Field>create_plan_properties_for_pk_scan()replaces row_id-specific variantGROUP BYon all PK columnsproject_to_pk_schema()UnionExecrustdoc links