chore: better code reuse in callback#145
Open
alexradzin wants to merge 3 commits intodatafusion-contrib:mainfrom
Open
chore: better code reuse in callback#145alexradzin wants to merge 3 commits intodatafusion-contrib:mainfrom
alexradzin wants to merge 3 commits intodatafusion-contrib:mainfrom
Conversation
added 2 commits
June 30, 2024 08:48
jimexist
approved these changes
Oct 4, 2024
caicancai
changed the title
caicancai
approved these changes
Nov 1, 2024
Collaborator
|
you probably need to run spotless apply first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small code improvement: created implementation of Consumer that is used 3 times as a callback. The removes the code duplication.