Make cost fn accept candidates #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xudong963
force-pushed
the
cost_refactor
branch
from
fb887f1 to
5c58264
Compare
xudong963
force-pushed
the
cost_refactor
branch
from
5c58264 to
04c69eb
Compare
suremarc
approved these changes
Sep 11, 2025
Collaborator
suremarc
left a comment
suremarc
left a comment
There was a problem hiding this comment.
Oops, I forgot to hit the approve button here.
Member
Author
|
Thank you @suremarc |
Closed
xudong963
added a commit
to massive-com/datafusion-materialized-views
that referenced
this pull request
Sep 15, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: I have two kinds of cost function, which need to consider all candidates then decide which one.
The PR extends the cost fn to accept a collection of candidates to make it flexible.