Skip to content

feat: set/show enhancement #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

feat: set/show enhancement #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 29 additions & 8 deletions datafusion-postgres/src/hooks/set_show.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,15 @@ where

client::set_statement_timeout(client, timeout);
return Some(Ok(Response::Execution(Tag::new("SET"))));
} else if matches!(var.as_str(), "datestyle" | "bytea_output" | "intervalstyle")
&& !values.is_empty()
} else if matches!(
var.as_str(),
"datestyle"
| "bytea_output"
| "intervalstyle"
| "application_name"
| "extra_float_digits"
| "search_path"
) && !values.is_empty()
{
// postgres configuration variables
let value = values[0].clone();
Expand All @@ -190,6 +197,13 @@ where
let tz = value.to_string();
let tz = tz.trim_matches('"').trim_matches('\'');
client::set_timezone(client, Some(tz));
// execution options for timezone
session_context
.state()
.config_mut()
.options_mut()
.execution
.time_zone = tz.to_string();
return Some(Ok(Response::Execution(Tag::new("SET"))));
}
_ => {}
Expand Down Expand Up @@ -249,7 +263,13 @@ where
Some(mock_show_response("TimeZone", timezone).map(Response::Query))
}
["server_version"] => {
Some(mock_show_response("server_version", "15.0 (DataFusion)").map(Response::Query))
let version = format!(
"datafusion {} on {} {}",
session_context.state().version(),
env!("CARGO_PKG_NAME"),
env!("CARGO_PKG_VERSION")
);
Some(mock_show_response("server_version", &version).map(Response::Query))
}
["transaction_isolation"] => Some(
mock_show_response("transaction_isolation", "read uncommitted").map(Response::Query),
Expand All @@ -259,10 +279,6 @@ where
let value = catalogs.join(", ");
Some(mock_show_response("Catalogs", &value).map(Response::Query))
}
["search_path"] => {
let default_schema = "public";
Some(mock_show_response("search_path", default_schema).map(Response::Query))
}
["statement_timeout"] => {
let timeout = client::get_statement_timeout(client);
let timeout_str = match timeout {
Expand All @@ -274,7 +290,12 @@ where
["transaction", "isolation", "level"] => {
Some(mock_show_response("transaction_isolation", "read_committed").map(Response::Query))
}
["bytea_output"] | ["datestyle"] | ["intervalstyle"] => {
["bytea_output"]
| ["datestyle"]
| ["intervalstyle"]
| ["application_name"]
| ["extra_float_digits"]
| ["search_path"] => {
let val = client
.metadata()
.get(&variables[0])
Expand Down
Loading