Improve pg_catalog type mapping#305
Open
mjgarton wants to merge 2 commits intodatafusion-contrib:masterfrom
Open
Improve pg_catalog type mapping#305mjgarton wants to merge 2 commits intodatafusion-contrib:masterfrom
mjgarton wants to merge 2 commits intodatafusion-contrib:masterfrom
Conversation
Instead of PgAttributeTable deciding how to map from arrow types to postgres types, delegate that decision to arrow-pg. This avoids duplicationm, brings consistency, and makes us more robust against future changes and additions to the mapping in arrow-pg.
Collaborator
Author
|
I haven't tested this much yet, but from a quick try it fixes the issue I was seeing and seems okay so far. |
sunng87
reviewed
Mar 10, 2026
| Field::new("attrelid", DataType::Int32, false), // OID of the relation this column belongs to | ||
| Field::new("attname", DataType::Utf8, false), // Column name | ||
| Field::new("atttypid", DataType::Int32, false), // OID of the column data type | ||
| Field::new("atttypid", DataType::UInt32, false), // OID of the column data type |
Member
There was a problem hiding this comment.
Can we keep this as int32? Because there is no native unsigned integer in postgres, using uint32 may introduces issues when we want to use this field with other UDFs.
Revert back to signed ints for iod since postgresql does not have support for unsigned ints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of PgAttributeTable deciding how to map from arrow types to postgres types, delegate that decision to arrow-pg. This avoids duplicationm, brings consistency, and makes us more robust against future changes and additions to the mapping in arrow-pg.