Multistatement Support #63
Conversation
|
@iPeluwa Thank you for the patch! The features added into this library look good to me. There are some format and lint issues. |
|
@iPeluwa you can run cargo clippy and cargo fmt locally to fix those lint and format issues |
…ster UDF for compatibility
sunng87
left a comment
sunng87
left a comment
There was a problem hiding this comment.
Again, please configure your editor to run format on save
| } | ||
| } | ||
| } | ||
| *sc_guard = new_context; |
There was a problem hiding this comment.
We already got this config mutable, why we need to recreate the whole session_context here?
datafusion-postgres/src/handlers.rs
Outdated
| // Build a ListArray containing "public" | ||
| let mut list_builder = ListBuilder::new(StringBuilder::new()); | ||
| for _ in 0..num_rows { | ||
| list_builder.values().append_value("public"); |
There was a problem hiding this comment.
Can we avoid hardcode public here? Is it possible to read schemas from SessionContext?
…ster UDF for compatibility
|
@iPeluwa any reason this patch is closed? Some of the content has been quite helpful to this library. If you agreed, I will pick up this by myself. |
|
I'm going to open a new PR, I decided it was best to Organize things much better and then reopen a PR.
|
3 participants
No description provided.