-
Notifications
You must be signed in to change notification settings - Fork 22
Feature/information schema support #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/information schema support #66
Conversation
…\n- Added , , and in for schema introspection using DataFusion catalogs.\n- Integrated queries in with , , and .\n- Implemented mock in to return , improving compatibility.\n- Enhanced with support, returning as the search path.\n- Refined query qualification in to exclude and , preventing planning errors.\n- Added debug logging in for incoming queries (requires dependency).\n- Updated with basic table registration and catalog name handling, setting the stage for further enhancements.\n- Updated to include dependency for debugging.\n\nNote: still uses and lacks integration; to be addressed in a future commit.
|
Awesome! This looks great to me. Thank you @iPeluwa for this great patch! |
| pgwire = { workspace = true } | ||
| datafusion = { workspace = true } | ||
| tokio = { version = "1.0", features = ["sync"] } | ||
| arrow = "54.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd better use arrow re-exported from datafusion. Otherwise we will have to trace arrow compatibility with datafusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, definitely agree with you.
|
The integration test is broken. It seems we can no longer access the table from default catalog/schema. Also it would be nice if you can include some integration tests for |
Yes ofcourse, I'd fix this and push in a bit |
|
@iPeluwa just connect you on linkedin. I'm curious about your use of this library (I guess you are using it in a project, right?). We can talk more about this. |
Yes Definitely. |
|
Hi @sunng87 ! Is there any plan to merge this? If there is any more capabilities required for this to be merged, maybe me and my team can contribute. Would love to hear your thoughts. |
|
We just need to get CI pass. @iPeluwa do you have time working on this? I can pick this up and move on. |
Yeah I would work on the CI passing today |
|
@sunng87 Currently working on this at the moment. |
|
@iPeluwa No problem. You can rebase to master and create a new PR. Thank you! |
@sunng87
Add information_schema support and enhance PostgreSQL compatibility
information_schema.schemata,tables, andcolumnsininformation_schema.rsfor schema introspection using DataFusion catalogs.information_schemaqueries inhandlers.rswithschemata_df,tables_df, andcolumns_df.pg_catalog.pg_namespaceinhandlers.rsto returncatalog_name, improvingpgclicompatibility.handlers.rswithSHOW search_pathsupport, returningcatalog_nameas the search path.do_queryto excludeinformation_schemaandpg_catalog, preventing planning errors.handlers.rsfor incoming queries (requireslogdependency).main.rswith basic table registration and catalog name handling, setting the stage for further enhancements.datafusion-postgres/Cargo.tomlto includelogdependency for debugging.Note:
main.rsstill usesprintln!and lackslogintegration; to be addressed in a future commit.