- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3.3k
refactor(ui): Remove V1 UI (round 2) #15147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| 🔴 Meticulous spotted visual differences in 1107 of 1109 screens tested: view and approve differences detected. Meticulous evaluated ~9 hours of user flows against your PR. Last updated for commit 4d73b92. This comment will update as new commits are pushed. | 
| Bundle ReportChanges will decrease total bundle size by 969.86kB (-3.39%) ⬇️. This is within the configured threshold ✅ Detailed changes
 Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
 Files in  
 | 
| ❌ 92 Tests Failed:
 View the top 3 failed test(s) by shortest run time
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 View the full list of 8 ❄️ flaky test(s)
 
 
 
 
 
 
 
 To view more test analytics, go to the Test Analytics Dashboard | 
Initially removed the
useIsThemeV2hook. Then, repeatedly called:to remove unnecessary exports / files and delete those unused variables.
Also deleted all tests in V1 directories so that this process would work better.