refactor(ui): Remove V1 UI (round 1) #15148

asikowitz · 2025-10-29T23:44:56Z

Removes usages of useIsThemeV2 to start getting rid of the V1 UI

alwaysmeticulous · 2025-10-29T23:51:06Z

🔴 Meticulous spotted visual differences in 106 of 1102 screens tested: view and approve differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

_{Last updated for commit c59f8e3. This comment will update as new commits are pushed.}

codecov · 2025-10-29T23:52:35Z

Bundle Report

Changes will decrease total bundle size by 758.17kB (-2.65%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
datahub-react-web-esm	27.82MB	-758.17kB (-2.65%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-*.js`	-741.23kB	18.21MB	-3.91%
`assets/index-*.css`	-11.51kB	597.94kB	-1.89%
~~*`assets/Globe-.svg`*~~ (Deleted)*	-5.43kB	0 bytes	-100.0% 🗑️

Files in assets/index-*.js:

./src/app/useShowNavBarRedesign.tsx → Total Size: 915 bytes
./src/app/entity/shared/entityForm/FormByEntity.tsx → Total Size: 1.72kB
./src/app/analyticsDashboard/components/AnalyticsPage.tsx → Total Size: 6.59kB
./src/app/settingsV2/SettingsPage.tsx → Total Size: 7.85kB
./src/app/SearchRoutes.tsx → Total Size: 4.57kB
./src/app/entity/shared/tabs/Properties/AddPropertyButton.tsx → Total Size: 5.8kB
./src/app/useSetAppTheme.tsx → Total Size: 1.44kB
./src/app/useBuildEntityRegistry.ts → Total Size: 121 bytes
./src/app/settingsV2/Preferences.tsx → Total Size: 3.06kB
./src/app/ProtectedRoutes.tsx → Total Size: 1.5kB
./src/app/onboarding/OnboardingTour.tsx → Total Size: 2.94kB
./src/CustomThemeProvider.tsx → Total Size: 489 bytes

codecov · 2025-10-30T00:04:27Z

❌ 49 Tests Failed:

Tests completed	Failed	Passed	Skipped
5128	49	5079	32

View the top 3 failed test(s) by shortest run time

run managed ingestion cypress/e2e/mutationsV2/v2_managed_ingestion.js::cypress/e2e/mutationsV2/v2_managed_ingestion.js

Stack Traces | 11.5s run time

2025-10-30T00:08:21.442Z
Timed out retrying after 10000ms: Expected to find content: 'Sources' but never did.

search cypress/e2e/search/searchFilters.js::cypress/e2e/search/searchFilters.js

Stack Traces | 11.5s run time

2025-10-30T00:30:36.039Z
Timed out retrying after 10000ms: Expected to find element: `input[data-testid=search-input]`, but never found it.

auto-complete cypress/e2e/auto_complete/auto_complete.js::cypress/e2e/auto_complete/auto_complete.js

Stack Traces | 11.5s run time

2025-10-30T00:00:13.818Z
Timed out retrying after 10000ms: `cy.type()` failed because the page updated while this command was executing. Cypress tried to locate elements based on this query:

> cy.get(input[data-testid=search-input])

We initially found matching element(s), but while waiting for them to become actionable, they disappeared from the page. Common situations why this happens:
  - Your JS framework re-rendered asynchronously
  - Your app code reacted to an event firing and removed the element

You can typically solve this by breaking up a chain. For example, rewrite:

> `cy.get('button').click().click()`

to

> `cy.get('button').as('btn').click()`
> `cy.get('@btn').click()`

https://on.cypress.io/element-has-detached-from-dom

manage views cypress/e2e/views/manage_views.js::cypress/e2e/views/manage_views.js

Stack Traces | 11.6s run time

2025-10-30T00:31:12.488Z
Timed out retrying after 10000ms: Expected to find content: 'Create new View' but never did.

home cypress/e2e/home/home.js::cypress/e2e/home/home.js

Stack Traces | 11.7s run time

2025-10-30T00:16:14.650Z
Timed out retrying after 10000ms: Expected to find element: `[data-testid="entity-type-browse-card-DATASET"]`, but never found it.

glossary cypress/e2e/glossaryV2/v2_glossary.js::cypress/e2e/glossaryV2/v2_glossary.js

Stack Traces | 11.9s run time

2025-10-30T00:14:59.503Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

manage ownership cypress/e2e/ownership/manage_ownership.js::cypress/e2e/ownership/manage_ownership.js

Stack Traces | 12s run time

2025-10-30T00:03:16.541Z
Timed out retrying after 10000ms: Expected to find element: `[data-testid="create-owner-type-v1"]`, but never found it.

search cypress/e2e/search/search.js::cypress/e2e/search/search.js

Stack Traces | 12s run time

2025-10-30T00:15:23.255Z
Timed out retrying after 10000ms: Expected to find element: `input[data-testid=search-input]`, but never found it.

docPropagation cypress/e2e/actions/docPropagation.js::cypress/e2e/actions/docPropagation.js

Stack Traces | 12.1s run time

2025-10-29T23:59:54.852Z
Timed out retrying after 10000ms: Expected to find element: `[data-testid="docPropagationIndicator"]`, but never found it.

lineage_graph cypress/e2e/lineage/lineage_graph.js::cypress/e2e/lineage/lineage_graph.js

Stack Traces | 12.1s run time

2025-10-30T00:03:01.199Z
Timed out retrying after 10000ms: Expected to find content: 'transaction_etl' but never did.

auto-complete dropdown, filter plus query search test "before each" hook for "cypress/e2e/search/query_and_filter_search.js"::cypress/e2e/search/query_and_filter_search.j

Stack Traces | 12.3s run time

2025-10-30T00:07:33.712Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

Because this error occurred during a `before each` hook we are skipping the remaining tests in the current suite: `auto-complete dropdown, fil...`

Verify nested domains test functionalities "before each" hook for "cypress/e2e/domains/nested_domains.js"::cypress/e2e/domains/nested_domains.j

Stack Traces | 12.3s run time

2025-10-30T00:01:33.965Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

Because this error occurred during a `before each` hook we are skipping the remaining tests in the current suite: `Verify nested domains test ...`

manage access tokens cypress/e2e/settings/manage_access_tokens.js::cypress/e2e/settings/manage_access_tokens.js

Stack Traces | 12.3s run time

2025-10-30T00:12:17.676Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

Manage Ingestion and Secret Privileges cypress/e2e/mutations/manage_ingestion_secret_privilege.js::cypress/e2e/mutations/manage_ingestion_secret_privilege.js

Stack Traces | 12.3s run time

2025-10-30T00:04:37.048Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

create announcement and link post "before each" hook for "cypress/e2e/settingsV2/v2_homePagePost.js"::cypress/e2e/settingsV2/v2_homePagePost.j

Stack Traces | 12.3s run time

2025-10-30T00:10:18.524Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

Because this error occurred during a `before each` hook we are skipping the remaining tests in the current suite: `create announcement and lin...`

run history tab in manage data sources "before each" hook for "cypress/e2e/ingestionV2/run_history.js"::cypress/e2e/ingestionV2/run_history.j

Stack Traces | 12.3s run time

2025-10-30T00:01:55.970Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

Because this error occurred during a `before each` hook we are skipping the remaining tests in the current suite: `run history tab in manage d...`

create announcement and link post "before each" hook for "cypress/e2e/settings/homePagePost.js"::cypress/e2e/settings/homePagePost.j

Stack Traces | 12.3s run time

2025-10-30T00:11:00.502Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

Because this error occurred during a `before each` hook we are skipping the remaining tests in the current suite: `create announcement and lin...`

column-Level lineage and impact analysis path test cypress/e2e/lineage/lineage_column_path.js::cypress/e2e/lineage/lineage_column_path.js

Stack Traces | 12.3s run time

2025-10-30T00:05:38.908Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

manage queries "before each" hook for "cypress/e2e/query/query_tab.js"::cypress/e2e/query/query_tab.j

Stack Traces | 12.3s run time

2025-10-30T00:04:33.636Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

Because this error occurred during a `before each` hook we are skipping the remaining tests in the current suite: `manage queries`

column-Level lineage and impact analysis path test cypress/e2e/lineageV2/v2_lineage_column_path.js::cypress/e2e/lineageV2/v2_lineage_column_path.js

Stack Traces | 12.4s run time

2025-10-30T00:06:56.127Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

download lineage results to .csv file cypress/e2e/lineageV2/v2_download_lineage_results.js::cypress/e2e/lineageV2/v2_download_lineage_results.js

Stack Traces | 12.4s run time

2025-10-30T00:05:39.681Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

managing secrets for ingestion creation cypress/e2e/mutations/managing_secrets.js::cypress/e2e/mutations/managing_secrets.js

Stack Traces | 12.4s run time

2025-10-30T00:08:14.418Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

operations cypress/e2e/operations/operations.js::cypress/e2e/operations/operations.js

Stack Traces | 12.4s run time

2025-10-30T00:09:40.998Z
Timed out retrying after 10000ms: Expected to find content: 'Last Updated' but never did.

Verify nested domains test functionalities "before each" hook for "cypress/e2e/domainsV2/v2_nested_domains.js"::cypress/e2e/domainsV2/v2_nested_domains.j

Stack Traces | 12.4s run time

2025-10-30T00:01:55.762Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

Because this error occurred during a `before each` hook we are skipping the remaining tests in the current suite: `Verify nested domains test ...`

glossary sidebar navigation test "before each" hook for "cypress/e2e/glossaryV2/v2_glossary_navigation.js"::cypress/e2e/glossaryV2/v2_glossary_navigation.j

Stack Traces | 12.4s run time

2025-10-30T00:01:33.839Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

Because this error occurred during a `before each` hook we are skipping the remaining tests in the current suite: `glossary sidebar navigation...`

glossaryTerm "before each" hook for "cypress/e2e/glossary/glossaryTerm.js"::cypress/e2e/glossary/glossaryTerm.j

Stack Traces | 12.4s run time

2025-10-30T00:00:46.613Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

Because this error occurred during a `before each` hook we are skipping the remaining tests in the current suite: `glossaryTerm`

download lineage results to .csv file cypress/e2e/lineage/download_lineage_results.js::cypress/e2e/lineage/download_lineage_results.js

Stack Traces | 12.4s run time

2025-10-30T00:00:31.810Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

glossaryTerm "before each" hook for "cypress/e2e/glossaryV2/v2_glossaryTerm.js"::cypress/e2e/glossaryV2/v2_glossaryTerm.j

Stack Traces | 12.4s run time

2025-10-30T00:00:16.069Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

Because this error occurred during a `before each` hook we are skipping the remaining tests in the current suite: `glossaryTerm`

ingestion source creation flow cypress/e2e/mutations/ingestion_source.js::cypress/e2e/mutations/ingestion_source.js

Stack Traces | 12.5s run time

2025-10-30T00:06:16.592Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

edit documentation and link to dataset cypress/e2e/mutations/edit_documentation.js::cypress/e2e/mutations/edit_documentation.js

Stack Traces | 12.5s run time

2025-10-30T00:08:27.545Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

ingestion sources "before each" hook for "cypress/e2e/ingestionV2/sources.js"::cypress/e2e/ingestionV2/sources.j

Stack Traces | 12.5s run time

2025-10-30T00:03:13.643Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

Because this error occurred during a `before each` hook we are skipping the remaining tests in the current suite: `ingestion sources`

create and manage platform and metadata policies "before each" hook for "cypress/e2e/settingsV2/v2_manage_policies.js"::cypress/e2e/settingsV2/v2_manage_policies.j

Stack Traces | 12.5s run time

2025-10-30T00:09:31.936Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

Because this error occurred during a `before each` hook we are skipping the remaining tests in the current suite: `create and manage platform ...`

add remove domain cypress/e2e/mutations/domains.js::cypress/e2e/mutations/domains.js

Stack Traces | 12.5s run time

2025-10-30T00:03:47.018Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

domains cypress/e2e/domains/domains.js::cypress/e2e/domains/domains.js

Stack Traces | 12.5s run time

2025-10-30T00:00:30.910Z
Timed out retrying after 10000ms: Expected to find content: 'SampleCypressKafkaDataset' but never did.

glossary cypress/e2e/glossary/glossary.js::cypress/e2e/glossary/glossary.js

Stack Traces | 12.5s run time

2025-10-30T00:00:27.889Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

ingestion source creation flow cypress/e2e/mutationsV2/v2_ingestion_source.js::cypress/e2e/mutationsV2/v2_ingestion_source.js

Stack Traces | 12.6s run time

2025-10-30T00:13:54.407Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

view select cypress/e2e/views/view_select.js::cypress/e2e/views/view_select.js

Stack Traces | 13.1s run time

2025-10-30T00:10:57.461Z
Timed out retrying after 10000ms: Expected to find element: `.ant-select[data-testid="view-select"] > .ant-select-selector > .ant-select-selection-search`, but never found it.

column-level lineage graph test cypress/e2e/lineage/lineage_column_level.js::cypress/e2e/lineage/lineage_column_level.js

Stack Traces | 13.4s run time

2025-10-30T00:04:21.349Z
Timed out retrying after 10000ms: Expected to find element: `[data-testid="column-toggle"]`, but never found it.

siblings cypress/e2e/siblings/siblings.js::cypress/e2e/siblings/siblings.js

Stack Traces | 14.1s run time

2025-10-30T00:21:03.247Z
Timed out retrying after 10000ms: Expected to find content: 'dbt & BigQuery' but never did.

login cypress/e2e/login/login.js::cypress/e2e/login/login.js

Stack Traces | 14.2s run time

2025-10-30T00:09:29.133Z
Timed out retrying after 10000ms: Expected to find content: 'Welcome back, DataHub' but never did.

dataset health test cypress/e2e/mutations/dataset_health.js::cypress/e2e/mutations/dataset_health.js

Stack Traces | 14.9s run time

2025-10-30T00:21:03.488Z
Timed out retrying after 10000ms: Expected to find element: `[href="/dataset/urn:li:dataset:(urn:li:dataPlatform:hive,cypress_health_test,PROD)/Quality"]`, but never found it.

dataset deprecation cypress/e2e/mutations/deprecations.js::cypress/e2e/mutations/deprecations.js

Stack Traces | 15.4s run time

2025-10-30T00:02:28.251Z
Timed out retrying after 10000ms: Expected to find element: `[data-testid="entity-header-dropdown"]`, but never found it.

features cypress/e2e/ml/feature_table.js::cypress/e2e/ml/feature_table.js

Stack Traces | 16.1s run time

2025-10-30T00:17:57.984Z
Timed out retrying after 10000ms: Expected to find content: '1 upstream, 1 downstream' but never did.

edit documentation and link to dataset cypress/e2e/mutationsV2/v2_edit_documentation.js::cypress/e2e/mutationsV2/v2_edit_documentation.js

Stack Traces | 18.9s run time

2025-10-30T00:10:39.537Z
Timed out retrying after 10000ms: Expected to find content: 'Link Added' but never did.

add_user cypress/e2e/mutations/add_users.js::cypress/e2e/mutations/add_users.js

Stack Traces | 19.8s run time

2025-10-30T00:11:25.568Z
Timed out retrying after 10000ms: Expected to find element: `[data-testid="manage-account-menu"]`, but never found it.

schema blame cypress/e2e/schema_blame/schema_blame.js::cypress/e2e/schema_blame/schema_blame.js

Stack Traces | 25.1s run time

2025-10-30T00:14:49.651Z
Timed out retrying after 10000ms: Expected to find element: `[data-testid="field_foo-schema-blame-description"]`, but never found it.

View the full list of 6 ❄️ flaky test(s)

Verify nested domains test functionalities cypress/e2e/domains/nested_domains.js::cypress/e2e/domains/nested_domains.js

Flake rate in main: 57.14% (Passed 60 times, Failed 80 times)

Stack Traces | 12.5s run time

2025-10-30T00:00:15.763Z
Timed out retrying after 10000ms: Expected to find element: `.anticon-plus`, but never found it.

add, remove ownership for dataset cypress/e2e/mutations/dataset_ownership.js::cypress/e2e/mutations/dataset_ownership.js

Flake rate in main: 40.00% (Passed 54 times, Failed 36 times)

Stack Traces | 17.9s run time

2025-10-30T00:18:30.561Z
Timed out retrying after 10000ms: Expected to find element: `[data-testid="add-owners-button"]`, but never found it.

impact analysis cypress/e2e/lineage/impact_analysis.js::cypress/e2e/lineage/impact_analysis.js

Flake rate in main: 100.00% (Passed 0 times, Failed 8 times)

Stack Traces | 4.71s run time

2025-10-30T00:01:25.139Z
`cy.click()` can only be called on a single element. Your subject contained 2 elements. Pass `{ multiple: true }` if you want to serially click each element.

https://on.cypress.io/click

manage access tokens cypress/e2e/settingsV2/v2_manage_access_tokens.js::cypress/e2e/settingsV2/v2_manage_access_tokens.js

Flake rate in main: 29.66% (Passed 83 times, Failed 35 times)

Stack Traces | 12.2s run time

2025-10-30T00:22:20.116Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

managing secrets for ingestion creation cypress/e2e/mutationsV2/v2_managing_secrets.js::cypress/e2e/mutationsV2/v2_managing_secrets.js

Flake rate in main: 36.36% (Passed 7 times, Failed 4 times)

Stack Traces | 12.3s run time

2025-10-30T00:01:49.486Z
Timed out retrying after 10000ms: Expected to find element: `.ant-avatar-circle`, but never found it.

search cypress/e2e/browse/browseV2.js::cypress/e2e/browse/browseV2.js

Flake rate in main: 30.77% (Passed 72 times, Failed 32 times)

Stack Traces | 12.2s run time

2025-10-30T00:05:06.773Z
Timed out retrying after 10000ms: Expected to find element: `input[data-testid=search-input]`, but never found it.

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

initial removal

c59f8e3

github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 29, 2025

github-actions bot deployed to datahub-project-web-react (Preview) October 29, 2025 23:50 View deployment

datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(ui): Remove V1 UI (round 1) #15148

refactor(ui): Remove V1 UI (round 1) #15148

Uh oh!

asikowitz commented Oct 29, 2025

Uh oh!

alwaysmeticulous bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

codecov bot commented Oct 29, 2025 •

edited

Loading

Assets Changed:

Uh oh!

codecov bot commented Oct 30, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

refactor(ui): Remove V1 UI (round 1) #15148

Are you sure you want to change the base?

refactor(ui): Remove V1 UI (round 1) #15148

Uh oh!

Conversation

asikowitz commented Oct 29, 2025

Uh oh!

alwaysmeticulous bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 49 Tests Failed:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alwaysmeticulous bot commented Oct 29, 2025 •

edited

Loading

codecov bot commented Oct 29, 2025 •

edited

Loading

codecov bot commented Oct 30, 2025 •

edited

Loading