Skip to content

chore(tests/mssql): update formatting of golden files#16735

Merged
ligfx merged 1 commit intomasterfrom
mm--mssql-golden-tests-reformat
Mar 24, 2026
Merged

chore(tests/mssql): update formatting of golden files#16735
ligfx merged 1 commit intomasterfrom
mm--mssql-golden-tests-reformat

Conversation

@ligfx
Copy link
Copy Markdown
Contributor

@ligfx ligfx commented Mar 23, 2026

No description provided.

@ligfx
Copy link
Copy Markdown
Contributor Author

ligfx commented Mar 23, 2026

@github-actions
Copy link
Copy Markdown
Contributor

Linear: ING-2038

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@askumar27 askumar27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Copy Markdown
Contributor

Your PR has been assigned to anush.kumar for review (ING-2038).

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous bot commented Mar 24, 2026

🔴 Meticulous spotted visual differences in 6 of 1579 screens tested: view and approve differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit 3929ce3. This comment will update as new commits are pushed.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Bundle Report

Changes will decrease total bundle size by 131 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 22.68MB -131 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js -131 bytes 12.45MB -0.0%

@ligfx ligfx changed the title style(tests/powerbi): update formatting of golden files chore(tests/mssql): update formatting of golden files Mar 24, 2026
@ligfx ligfx merged commit 2644939 into master Mar 24, 2026
91 of 122 checks passed
@ligfx ligfx deleted the mm--mssql-golden-tests-reformat branch March 24, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants