Skip to content

chore(tests/mssql): update formatting of golden files - #16735

Merged
ligfx merged 1 commit into
masterfrom
mm--mssql-golden-tests-reformat
Mar 24, 2026
Merged

chore(tests/mssql): update formatting of golden files#16735
ligfx merged 1 commit into
masterfrom
mm--mssql-golden-tests-reformat

Conversation

@ligfx

@ligfx ligfx commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@ligfx

ligfx commented Mar 23, 2026

Copy link
Copy Markdown
Contributor Author

@github-actions

Copy link
Copy Markdown
Contributor

Linear: ING-2038

@codecov

codecov Bot commented Mar 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@askumar27 askumar27 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions

Copy link
Copy Markdown
Contributor

Your PR has been assigned to anush.kumar for review (ING-2038).

@alwaysmeticulous

alwaysmeticulous Bot commented Mar 24, 2026

Copy link
Copy Markdown

🔴 Meticulous spotted visual differences in 6 of 1579 screens tested: view and approve differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit 3929ce3. This comment will update as new commits are pushed.

@codecov

codecov Bot commented Mar 24, 2026

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 131 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 22.68MB -131 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js -131 bytes 12.45MB -0.0%

@ligfx ligfx changed the title style(tests/powerbi): update formatting of golden files chore(tests/mssql): update formatting of golden files Mar 24, 2026
@ligfx
ligfx merged commit 2644939 into master Mar 24, 2026
91 of 122 checks passed
@ligfx
ligfx deleted the mm--mssql-golden-tests-reformat branch March 24, 2026 23:20
david-leifker pushed a commit that referenced this pull request May 27, 2026
- docs(free trials): updating free trial links (#16758)
- docs(readme): Add link for Free Cloud Trial on Readme (#16753)
- fix(vertica): remove accidental pytest import from source file (#16763)
- docs(readme): Remove Roadmap link from README (#16765)
- chore(tests/mssql): update formatting of golden files (#16735)
- feat(ingest/powerbi): support 'Sql.Databases' M-Query data access function (#16616)
- fix(ingest/mssql): lowercase field paths when convert_urns_to_lowercase=True (#16736)
- feat(cli): add `datahub init --sso` for browser-based SSO login (#16715)
- feat(cli): add --context / -C flag for passing context in event properties (#16764)
- build(ingest): bump python-liquid from <2 to >=2.0.0,<3.0.0 (#16697)
- chore(docs): Update docs for summary pages, multiple data products, and ingestion (#16584)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants