Skip to content

fix(ingestion): Bump up pyodbc upper constraint#16746

Merged
kyungsoo-datahub merged 9 commits intomasterfrom
fix/bump-up-pyodbc-version
Mar 31, 2026
Merged

fix(ingestion): Bump up pyodbc upper constraint#16746
kyungsoo-datahub merged 9 commits intomasterfrom
fix/bump-up-pyodbc-version

Conversation

@kyungsoo-datahub
Copy link
Copy Markdown
Contributor

@kyungsoo-datahub kyungsoo-datahub commented Mar 24, 2026

Summary

  • Bump pyodbc upper bound from <5.0 to <6.0 in fabric-onelake, all, and integration-tests extras
  • Regenerate uv.lock and constraints.txt (4.0.39 → 5.3.0)

Why

pyodbc 4.x has no Python 3.12 binary wheels.

Why the major version bump is safe

pyodbc 5.0 bumped the major version solely to drop Python 2. The release notes state: "The API is backwards compatible, so previous Python 3 products using pyodbc should not need any changes." No changes to connect(), Connection, Cursor, Row, or data type handling across 5.0–5.3.

Our usage (pyodbc.connect() with attrs_before, add_output_converter, mssql+pyodbc:// SQLAlchemy dialect) is all stable API. The one 5.0.0 regression (bytes in attrs_before) was fixed in 5.0.1; we pin to 5.3.0.

@github-actions
Copy link
Copy Markdown
Contributor

Linear: ING-2049

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 24, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@datahub-connector-tests
Copy link
Copy Markdown

datahub-connector-tests bot commented Mar 24, 2026

Connector Tests Results

All connector tests passed for commit f9fcdb7

View full test logs →

To skip connector tests, add the skip-connector-tests label (org members only).

Autogenerated by the connector-tests CI pipeline.

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous bot commented Mar 24, 2026

🔴 Meticulous spotted visual differences in 1 of 1553 screens tested: view and approve differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit 5810ecb Cosmetic issue. This comment will update as new commits are pushed.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Bundle Report

Changes will increase total bundle size by 23 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 22.7MB 23 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 23 bytes 12.45MB 0.0%

@github-actions
Copy link
Copy Markdown
Contributor

Your PR has been assigned to anush.kumar for review (ING-2049).

@kyungsoo-datahub kyungsoo-datahub merged commit 755ab21 into master Mar 31, 2026
75 checks passed
@kyungsoo-datahub kyungsoo-datahub deleted the fix/bump-up-pyodbc-version branch March 31, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants