Add functions to export a wiki article as a PDF #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FChataigner
requested changes
Nov 26, 2020
dataikuapi/dss/wiki.py
Outdated
| """ | ||
| Download the whole wiki of the project in PDF format into the given output file. | ||
| """ | ||
| stream = self.get_export_stream(paperSize=paperSize, exportAttachment=exportAttachment) |
Contributor
There was a problem hiding this comment.
is it possible to use with ... as stream: instead of the get/do/close construction? (if the stream can handle it)
Contributor
Author
There was a problem hiding this comment.
I added it, it's indeed neater. Also I used underscores instead of camelCase for parameter names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ch55059
Need an instance with at least dip#11418 merged (not on master yet)