[sc-47182] GKE plugin: log API calls #22
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #47182: GKE plugin: log API calls. |
nikopol
approved these changes
Feb 17, 2023
| logging.info("Clusterrolebinding already exist") | ||
| logging.info("ClusterRoleBinding already exists") | ||
| else: | ||
| logging.info("Creating ClusterRoleBinding with KUBECONFIG=%s" % kube_config_path) |
Contributor
There was a problem hiding this comment.
the kube config path is already log before, but I guess the repetition doesn't harm anyone ;)
jules-casoli
approved these changes
Mar 7, 2023
Contributor
Author
|
Putting this PR on hold until we decide what we want to do with it regarding [sc-105893] |
|
This pull request has been linked to Shortcut Story #105893: [AKS/EKS/GKE] Identify and hide secrets in plugin logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.shortcut.com/dataiku/story/47182
[SC-47182]