Task/add gateway api #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjestin-dku
approved these changes
Jan 6, 2026
Contributor
pjestin-dku
left a comment
pjestin-dku
left a comment
There was a problem hiding this comment.
Change LGTM. I tested by creating a GKE cluster with the PR branch: I see gateway API is enabled in the cluster.
amandineslx
approved these changes
Jan 6, 2026
Contributor
amandineslx
left a comment
amandineslx
left a comment
There was a problem hiding this comment.
OK for me
Review
- code review
- ✅ check added option against API documentation
- provision DSS in elastic design fleet with FM in GCP
- upgrade plugin with the one built from the PR branch (commit
14764046e83dbc3127c5b0643c8d23b506a4f9c3) - ✅ start cluster with gateway API option ticked
- ✅ check the corresponding option is activated in the cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sc-277380]
note that the Gateway API must be enabled on the project for the GKE cluster to have it