Major Changes! Modernize, add new features, adapt to the latest kpms version, pipeline redesign, new report schema#17
Merged
ttngu207 merged 63 commits intodatajoint:mainfrom Sep 16, 2025
Conversation
: add removal of outlier keypoints, fix generation and udpate of config yml file, rename table from PCAPre to PreProcessing, add new attribute, add 3-part make function
moseq_train pipeline design, preprocessing, readerskeypoint-moseq with new incompatible features & modernize env and config
ttngu207
requested changes
Sep 8, 2025
ttngu207
reviewed
Sep 16, 2025
ttngu207
reviewed
Sep 16, 2025
ttngu207
reviewed
Sep 16, 2025
ttngu207
reviewed
Sep 16, 2025
…e re-running a session
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 13 out of 17 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ttngu207
previously approved these changes
Sep 16, 2025
The merge-base changed after approval.
ttngu207
previously approved these changes
Sep 16, 2025
The merge-base changed after approval.
ttngu207
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
element-moseq v1.0.0: Major Refactor with Breaking Changes
This pull request delivers a comprehensive refactor of the
element-moseqproject, focusing on environment management, configuration handling, and pipeline enhancements. Most notably, the code is updated to work with the latest version ofkeypoint-moseq, introduces new features that are incompatible with previouselement-moseqversions, and modernizes the development and packaging setup.Breaking Changes
keypoint-mosequpdated from pinned0.4.8to the latest upstream version (installed from source)element-moseqversions:kpms_readerfunctions to generate, load, and update kpms config filesPCAPreptoPreProcessingtable and add new attributesPreProcessingtable with newoutlier_scale_factorattribute inPCATask(only available in latest version of kpms)sigmasq_locfeature inPreFitandFullFitto automatically estimate sigmasq_loc (prior controlling the centroid movement across frames) (only available in latest version of kpms)PreProcessingtable to use 3-part make function with newVideopart tableThese changes require database and pipeline alignment with the latest
keypoint-moseqconventions.New Features
reportschema with comprehensive reporting capabilitiesplottingmodule with refactoredviz_utilsfor better organizationPreProcessingtable with 3-part make function, newVideopart table, and attributesvideo_duration,frame_rate, andaverage_frame_rateconfig.ymlandconfig.yaml)Environment & Packaging Modernization
setup.py→pyproject.tomlandconda_env.yml, aligning with modern Python packaging standardspyproject.tomlConfiguration & Path Handling
keypoint-moseqlogicmoseq_infer.py,moseq_train.py,report.py) to ensure consistent, maintainable DataJoint config handlingPathobjects and robust existence checksmoseq_inferpaths and applied 3-part make functionPreFitandFullFitBug Fixes & Improvements
PreProcessingtableInferencetableModelimported foreign keyImpact Summary