feat: convert abs path for dataset in object store

[Dludora]

As the title says

[gemini-code-assist]

Summary of Changes

Hello @Dludora, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the system's ability to handle dataset paths, particularly those residing in various object storage systems. By expanding the definition of what constitutes a remote path and refining the logic for resolving absolute paths, the changes ensure more robust and accurate access to datasets, whether they are local or stored in cloud environments like S3, GCS, or HDFS.

Highlights

• Enhanced Remote Path Detection: The is_remote_path utility function has been updated to recognize additional cloud object storage protocols, specifically "s3://", "gs://", and "hdfs://", alongside existing HTTP/HTTPS checks.
• Improved Absolute Path Resolution: The get_abs_path function now re-evaluates whether a path is remote after it has been joined with the dataset_dir. This ensures that paths that become remote (e.g., "s3://bucket/path") after concatenation are correctly identified and handled as remote.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• data_juicer/core/data/ray_dataset.py
  • Modified get_abs_path to check if a path becomes remote after being joined with dataset_dir before attempting to resolve it as a local absolute path.
• data_juicer/utils/file_utils.py
  • Extended the is_remote_path function to include "s3://", "gs://", and "hdfs://" as recognized remote path prefixes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enhances support for datasets located in object stores by updating path handling logic. The is_remote_path function is expanded to recognize s3://, gs://, and hdfs:// schemes. The get_abs_path function is correctly modified to handle cases where dataset_dir is a remote path, preventing incorrect path resolution by os.path.abspath. The changes are correct and well-targeted. I've added one suggestion to improve the readability of the logic in get_abs_path.