feat: changed endpoint parameter name from experiment_run_id -> model…#185
Merged
vishpillai123 merged 2 commits intodevelopfrom Nov 17, 2025
Merged
feat: changed endpoint parameter name from experiment_run_id -> model…#185vishpillai123 merged 2 commits intodevelopfrom
vishpillai123 merged 2 commits intodevelopfrom
Conversation
| job_run_id: str, | ||
| current_user: Annotated[BaseUser, Depends(get_current_active_user)], | ||
| sql_session: Annotated[Session, Depends(get_session)], | ||
| ) -> List[dict[str, Any]]: |
Contributor
There was a problem hiding this comment.
Were we running into type check failures here?
Collaborator
Author
There was a problem hiding this comment.
No. But also, we haven't made much changes to this specific file, we've been pushing changes to models.py.
The check error makes sense though, because it returns either rows as a variable or raises an exception (returns nothing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: changed endpoint parameter name from experiment_run_id -> model…