Skip to content

fix: use full test dataset for support overview training table #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vishpillai123 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: use full test dataset for support overview training table #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92682ca
feat: use full test dataset for support_overview table
Mar 3, 2026
dbc4366
Merge branch 'develop' into feat/support-overview-full-test-dataset
vishpillai123 Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/edvise/scripts/predictions_h2o.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ def run_predictions(
*,
run_type: RunType,
df_inference: pd.DataFrame | None = None,
test_sample_cap: int = 200,
test_sample_cap: int | None = 200,
) -> PredOutputs:
ft = load_features_table(pred_paths.features_table_path)
model, model_feature_names = load_model_and_features(pred_cfg.model_run_id)
Expand All @@ -268,12 +268,16 @@ def run_predictions(
df_train, df_test_all = extract_and_split_training_data(
pred_cfg.experiment_id, pred_cfg.split_col
)
df_test = sample_rows(
df_test_all,
min(test_sample_cap, len(df_test_all)),
pred_cfg.random_state,
"df_test(train)",
)
if test_sample_cap is None:
# Use full test dataset when test_sample_cap is None
df_test = df_test_all.copy()
else:
df_test = sample_rows(
df_test_all,
min(test_sample_cap, len(df_test_all)),
pred_cfg.random_state,
"df_test(train)",
)
else:
# PREDICT: inference input
df_test = df_inference
Expand Down
7 changes: 6 additions & 1 deletion src/edvise/scripts/training_h2o.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,8 +372,13 @@ def make_predictions(self, current_run_path):
label="Training SHAP Feature Importance table",
)

# Generate support_overview using full test dataset (same as ROC table)
logging.info("Generating support_overview table from full test dataset")
out_full = run_predictions(
pred_cfg=cfg, pred_paths=paths, run_type=RunType.TRAIN, test_sample_cap=None
)
self.write_delta(
df=out.support_score_distribution,
df=out_full.support_score_distribution,
table_name_suffix=f"training_{self.cfg.model.run_id}_support_overview",
label="Training Support Overview table",
)
Expand Down
Loading