Skip to content

improve fulltext upload endpoint visibility#170

Merged
bdewilde merged 4 commits intodevelopfrom
fix-fulltext-upload-api-maybe
Dec 22, 2025
Merged

improve fulltext upload endpoint visibility#170
bdewilde merged 4 commits intodevelopfrom
fix-fulltext-upload-api-maybe

Conversation

@bdewilde
Copy link
Member

@bdewilde bdewilde commented Dec 21, 2025

changes

  • improves logging when uploading fulltext files
  • improves type/schema when getting uploaded files

context

https://app.asana.com/1/6325821815997/project/1206730431337718/task/1212482984883058?focus=true

@sophiaharms I was not able to reproduce your error. That said, I could break this setup by providing faulty env vars in the .env file -- is it possible that's what happening on your side?

questions

@bdewilde bdewilde marked this pull request as ready for review December 21, 2025 19:52
@sophiaharms
Copy link
Contributor

@bdewilde is it expected behavior that when there is no fulltext file uploaded for a citation, the response is Internal Server Error? Or are you able to return a positive null?

@bdewilde
Copy link
Member Author

@bdewilde is it expected behavior that when there is no fulltext file uploaded for a citation, the response is Internal Server Error? Or are you able to return a positive null?

@sophiaharms If the file doesn't exist, the API should return a "not found error" w/ status code 404, like this:

{
  "detail": {},
  "message": "no uploaded file for <Study(id=1)> found"
}

Are you not seeing that?

@bdewilde bdewilde merged commit aeb6928 into develop Dec 22, 2025
4 checks passed
@bdewilde bdewilde deleted the fix-fulltext-upload-api-maybe branch December 22, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants