Skip to content

Include bool search query with review plan#181

Merged
bdewilde merged 4 commits intodevelopfrom
include-bool-search-query-with-plan
Jan 17, 2026
Merged

Include bool search query with review plan#181
bdewilde merged 4 commits intodevelopfrom
include-bool-search-query-with-plan

Conversation

@bdewilde
Copy link
Member

@bdewilde bdewilde commented Jan 7, 2026

changes

  • adds option to include hybrid properties in addition to columns when turning a db model into a dict
  • leverages that option to include boolean search queries with review plans

context

https://app.asana.com/1/6325821815997/project/1206730431337718/task/1212678227902739?focus=true

questions


Note

Surfaces hybrid properties in API responses for review plans.

  • Extend model_to_dict with include_hybrid to include SQLAlchemy hybrid_property fields
  • Use this in GET /reviews/<id>/plan to return boolean_search_query when requested (or by default field set)
  • Update tests to validate boolean_search_query retrieval via fields filtering

Written by Cursor Bugbot for commit b81cdb7. This will update automatically on new commits. Configure here.

@bdewilde bdewilde marked this pull request as ready for review January 7, 2026 01:42
@bdewilde bdewilde requested a review from sophiaharms January 7, 2026 01:42
@bdewilde
Copy link
Member Author

@sophiaharms this change is meant to address an issue noted in user testing -- shall I merge it?

@bdewilde bdewilde merged commit e4577f7 into develop Jan 17, 2026
7 checks passed
@bdewilde bdewilde deleted the include-bool-search-query-with-plan branch January 17, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant