Feat: Added backfill endpoint #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishpillai123
approved these changes
Oct 23, 2025
| from datetime import datetime | ||
| from typing import Annotated, Any, cast | ||
| import jsonpickle | ||
| from fastapi import APIRouter, Depends, HTTPException, status |
Contributor
There was a problem hiding this comment.
wow this Depends logic is cool
| current_user: Annotated[BaseUser, Depends(get_current_active_user)], | ||
| sql_session: Annotated[Session, Depends(get_session)], | ||
| databricks_control: Annotated[DatabricksControl, Depends(DatabricksControl)], | ||
| ) -> Any: |
Contributor
There was a problem hiding this comment.
can we just add some quick documentation here saying that this will backfill the LATEST model run ID, and to use this endpoint carefully in the future? Maybe we should delete this later.. we'll figure it out.
| mv_version = str(latest_mv.version) | ||
| mv_run_id = str(latest_mv.run_id) | ||
|
|
||
| # UPDATE existing jobs for this model (only those missing values) |
Contributor
There was a problem hiding this comment.
ah so this only updates if it's missing? I like that... it'll prevent someone from messing up the table in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes
POST /{inst_id}/models/{model_name}/backfill-model-runsto fetch latest UC model version and update jobs with missing fields.context
questions
No questions at this time.