Fix HF device selection to support non-CUDA#21
Open
tabtablabs-dev wants to merge 1 commit intodatalab-to:masterfrom
Open
Fix HF device selection to support non-CUDA#21tabtablabs-dev wants to merge 1 commit intodatalab-to:masterfrom
tabtablabs-dev wants to merge 1 commit intodatalab-to:masterfrom
Conversation
|
On my Macbook Pro (M3 Pro with 18GB of RAM) it fails. The error I get is the following:
|
|
I somehow managed to let it work by removing the def load_model():
# device_map = "auto"
# if settings.TORCH_DEVICE:
# device_map = {"": settings.TORCH_DEVICE}
# kwargs = {
# "dtype": settings.TORCH_DTYPE,
# "device_map": device_map,
# }
# if settings.TORCH_ATTN:
# kwargs["attn_implementation"] = settings.TORCH_ATTN
model = Qwen3VLForConditionalGeneration.from_pretrained(
settings.MODEL_CHECKPOINT,
# **kwargs
)So, I guess either the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_devicehelper so the Qwen HF path can run on CUDA, MPS, or CPU without changing settingssettings.TORCH_DEVICEwhen providedTesting
ty check(fails: existing invalid-argument-type and typing errors unrelated to this change)