Skip to content

feat:support gateway kernel client #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2025
+5 −1
Merged

feat:support gateway kernel client #45

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3000d8d
support gateway kernel client
Jun 24, 2025
0a2f5da
Update jupyter_server_nbmodel/actions.py
dualc Jun 25, 2025
5d70ac9
Update jupyter_server_nbmodel/actions.py
dualc Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion jupyter_server_nbmodel/actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def _stdin_hook(kernel_id: str, request_id: str, pending_input: PendingInput, ms
f"Execution request {kernel_id} received a input request while waiting for an input.\n{msg}" # noqa: E501
)
header = msg["header"].copy()
header["date"] = header["date"].isoformat()
header["date"] = header["date"] if isinstance(header["date"], str) else header["date"].isoformat()
pending_input.request_id = request_id
pending_input.content = InputDescription(
parent_header=header, input_request=InputRequest(**msg["content"])
Expand Down Expand Up @@ -269,6 +269,10 @@ async def kernel_worker(
client.session.session = uid
# FIXME
# client.session.username = username
from jupyter_server.gateway.managers import GatewayKernelClient
if isinstance(client, GatewayKernelClient) and client.channel_socket is None:
get_logger().debug(f"start channels {kernel_id}")
await client.start_channels()
results[uid] = await _execute_snippet(
client, ydoc, snippet, metadata, partial(_stdin_hook, kernel_id, uid, pending_input)
)
Expand Down
Loading