feat: BI-6829 dl obfuscator base package #1429
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new base obfuscator package (dl_obfuscator) that provides functionality for obfuscating sensitive data like secrets and query parameters in various contexts (logs, Sentry, tracing, usage tracking, and inspector).
Key Changes:
- New
dl_obfuscatorpackage with core obfuscation engine and secret keeper registry - Support for context-aware obfuscation (different rules for logs vs. inspector)
- Extensible architecture with base obfuscator class for custom implementations
Reviewed changes
Copilot reviewed 13 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| metapkg/pyproject.toml | Adds dl-obfuscator to the metapackage dependencies |
| lib/dl_obfuscator/pyproject.toml | Package configuration defining dependencies and test settings |
| lib/dl_obfuscator/dl_obfuscator/secret_keeper.py | Registry for storing secrets and query parameters to be obfuscated |
| lib/dl_obfuscator/dl_obfuscator/engine.py | Core obfuscation engine with text and dict processing methods |
| lib/dl_obfuscator/dl_obfuscator/context.py | Enum defining obfuscation contexts (logs, sentry, tracing, etc.) |
| lib/dl_obfuscator/dl_obfuscator/obfuscators/base.py | Abstract base class for custom obfuscators |
| lib/dl_obfuscator/dl_obfuscator/init.py | Package initialization with public API exports |
| lib/dl_obfuscator/dl_obfuscator_tests/unit/test_secret_keeper.py | Unit tests for SecretKeeper functionality |
| lib/dl_obfuscator/dl_obfuscator_tests/unit/test_engine.py | Unit tests for ObfuscationEngine behavior |
| lib/dl_obfuscator/dl_obfuscator_tests/unit/conftest.py | Pytest fixtures for tests |
| lib/dl_obfuscator/README.md | Basic package documentation |
| lib/dl_obfuscator/LICENSE | Apache 2.0 license file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lib/dl_obfuscator/dl_obfuscator_tests/unit/test_secret_keeper.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 17 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 18 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lib/dl_obfuscator/dl_obfuscator_tests/unit/test_secret_keeper.py
Outdated
Show resolved
Hide resolved
No description provided.