feat: BI-6373 Pydantic connector settings #1445
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vallbull
force-pushed
the
new_conn_settings
branch
from
d73ab54 to
2b4f33d
Compare
ovsds
reviewed
Jan 23, 2026
| from dl_api_lib.app_settings import ( | ||
| ControlApiAppSettingsOS, | ||
| ControlApiAppTestingsSettings, | ||
| DeprecatedControlApiAppSettingsOS, |
ovsds
approved these changes
Jan 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates connector settings from a deprecated attrs-based configuration system to a new Pydantic-based settings framework. The migration removes fallback mechanisms and simplifies the connector settings architecture.
Changes:
- Removed deprecated connector settings classes and their fallback functions across all connectors
- Updated connector settings to use Pydantic models inheriting from
ConnectorSettings - Changed connector settings dictionaries to use string keys (connection type values) instead of
ConnectionTypeenum keys - Removed unused dependencies and imports related to the old settings system
Reviewed changes
Copilot reviewed 103 out of 103 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/dl_maintenance/dl_maintenance/api/common.py | Simplified connector settings loading by returning empty dict instead of using deprecated loader |
| lib/dl_file_uploader_worker_lib/dl_file_uploader_worker_lib/settings.py | Removed deprecated connector settings classes and fallback functions |
| lib/dl_file_uploader_worker_lib/dl_file_uploader_worker_lib_tests/conftest.py | Updated fixtures to use new Pydantic settings with string-keyed dictionaries |
| lib/dl_core/dl_core/connectors/settings/registry.py | Removed deprecated settings registry infrastructure |
| lib/dl_core/dl_core/connectors/settings/primitives.py | Removed deprecated settings helper functions |
| lib/dl_core/dl_core/connectors/settings/mixins.py | Removed deprecated settings mixins |
| lib/dl_core/dl_core/services_registry/top_level.py | Updated service registry to use string-keyed connector settings |
| lib/dl_connector_*/core/settings.py | Migrated all connector-specific settings from attrs to Pydantic models |
| lib/dl_connector_bundle_chs3/chs3_base/core/settings.py | Migrated FileS3 connector settings to Pydantic with nested root settings |
| lib/dl_configs/dl_configs/connectors_settings.py | Removed entire file containing deprecated base classes |
| lib/dl_configs/dl_configs/settings_loaders/loader_env.py | Removed deprecated connector settings loader function |
| lib/dl_api_lib/dl_api_lib/app_settings.py | Added ConnectorsSettingsMixin to new settings classes |
| app/dl_data_api/dl_data_api/app.py | Updated to load connectors settings directly from app settings instead of using separate loader |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.