-
Notifications
You must be signed in to change notification settings - Fork 40
feat: BI-6156 add dt postprocessing to dashsql #1465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements datetime postprocessing for DashSQL queries, standardizing datetime output to ISO 8601 format (YYYY-MM-DDTHH:MM:SS) across different database connectors.
Changes:
- Added type annotations and removed a type-ignore comment in the query processing postprocessors module
- Updated DashSQL datetime formatting from space-separated to ISO 8601 T-separated format in test expectations
- Implemented type-aware postprocessing in DashSQL resource handler with error handling for datetime and array types
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/dl_query_processing/dl_query_processing/postprocessing/postprocessors/all.py | Added type hints to TYPE_PROCESSORS dictionary and removed type-ignore comment |
| lib/dl_connector_trino/dl_connector_trino_tests/db/api/test_dashsql.py | Updated expected datetime format in test assertion from space-separated to ISO 8601 format |
| lib/dl_connector_clickhouse/dl_connector_clickhouse_tests/db/api/test_dashsql.py | Updated expected datetime formats in test assertions to ISO 8601 format |
| lib/dl_api_lib/dl_api_lib_tests/db/data_api/test_dashsql.py | Added comprehensive tests for datetime and array postprocessing with ISO 8601 validation |
| lib/dl_api_lib/dl_api_lib/app/data_api/resources/dashsql.py | Implemented type-aware postprocessing logic with datetime and array handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.