Skip to content

Conversation

@chl0rum
Copy link
Contributor

@chl0rum chl0rum commented Jan 22, 2026

No description provided.

@github-actions github-actions bot added the type/feat New features label Jan 22, 2026
@ovsds ovsds requested a review from Copilot January 23, 2026 17:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements datetime postprocessing for DashSQL queries, standardizing datetime output to ISO 8601 format (YYYY-MM-DDTHH:MM:SS) across different database connectors.

Changes:

  • Added type annotations and removed a type-ignore comment in the query processing postprocessors module
  • Updated DashSQL datetime formatting from space-separated to ISO 8601 T-separated format in test expectations
  • Implemented type-aware postprocessing in DashSQL resource handler with error handling for datetime and array types

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
lib/dl_query_processing/dl_query_processing/postprocessing/postprocessors/all.py Added type hints to TYPE_PROCESSORS dictionary and removed type-ignore comment
lib/dl_connector_trino/dl_connector_trino_tests/db/api/test_dashsql.py Updated expected datetime format in test assertion from space-separated to ISO 8601 format
lib/dl_connector_clickhouse/dl_connector_clickhouse_tests/db/api/test_dashsql.py Updated expected datetime formats in test assertions to ISO 8601 format
lib/dl_api_lib/dl_api_lib_tests/db/data_api/test_dashsql.py Added comprehensive tests for datetime and array postprocessing with ISO 8601 validation
lib/dl_api_lib/dl_api_lib/app/data_api/resources/dashsql.py Implemented type-aware postprocessing logic with datetime and array handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chl0rum chl0rum requested a review from khamitovdr January 26, 2026 21:43
@chl0rum chl0rum merged commit 1f78a9e into main Jan 27, 2026
61 checks passed
@chl0rum chl0rum deleted the chl0rum/dashsql-postprocessing branch January 27, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feat New features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants