Skip to content

Conversation

@ovsds
Copy link
Contributor

@ovsds ovsds commented Jan 23, 2026

No description provided.

@github-actions github-actions bot added the type/feat New features label Jan 23, 2026
@ovsds ovsds requested a review from Copilot January 23, 2026 17:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the authentication system by renaming NoAuthChecker to AlwaysAllowAuthChecker for clarity and introduces a new AlwaysDenyAuthChecker that always denies authentication. This improves the semantic clarity of the authentication checkers and adds functionality for routes that should always be denied access.

Changes:

  • Renamed NoAuthChecker to AlwaysAllowAuthChecker and NoAuthResult to AlwaysAllowAuthResult throughout the codebase
  • Added new AlwaysDenyAuthChecker and AlwaysDenyAuthResult classes that always raise AuthFailureError
  • Updated test endpoints from /api/v1/no_auth/ping to /api/v1/always_allow/ping and added /api/v1/always_deny/ping

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
lib/dl_app_api_base/dl_app_api_base/auth/checkers/no_auth.py Removed the old NoAuthChecker implementation
lib/dl_app_api_base/dl_app_api_base/auth/checkers/always_allow.py Added new AlwaysAllowAuthChecker (renamed from NoAuthChecker)
lib/dl_app_api_base/dl_app_api_base/auth/checkers/always_deny.py Added new AlwaysDenyAuthChecker that always denies authentication
lib/dl_app_api_base/dl_app_api_base/auth/checkers/init.py Updated exports to replace NoAuthChecker with new auth checkers
lib/dl_app_api_base/dl_app_api_base/auth/init.py Updated auth module exports with renamed and new checkers
lib/dl_app_api_base/dl_app_api_base/init.py Updated main module exports with renamed and new checkers
lib/dl_app_api_base/dl_app_api_base/app.py Updated usage of NoAuthChecker to AlwaysAllowAuthChecker
lib/dl_app_api_base/dl_app_api_base_tests/unit/conftest.py Updated test configuration with renamed checkers and new test routes
lib/dl_app_api_base/dl_app_api_base_tests/unit/auth/middleware/test_always_allow.py Updated test to use new endpoint path /api/v1/always_allow/ping
lib/dl_app_api_base/dl_app_api_base_tests/unit/auth/middleware/test_always_deny.py Added test for new AlwaysDenyAuthChecker functionality
lib/dl_app_api_base/dl_app_api_base_tests/unit/handlers/docs/expected_spec.json Updated OpenAPI spec with new endpoint paths

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ovsds ovsds force-pushed the ovsds/auth-add-always-deny branch from cd2b1f8 to e8927e4 Compare January 23, 2026 17:05
@ovsds ovsds merged commit 222707f into main Jan 26, 2026
31 of 33 checks passed
@ovsds ovsds deleted the ovsds/auth-add-always-deny branch January 26, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feat New features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants