Workbook access dialog legacy by YankinA · Pull Request #3022 · datalens-tech/datalens-ui

YankinA · 2025-10-15T10:00:41Z

No description provided.

github-actions · 2025-10-15T10:04:11Z

📦 Statoscope quick diff with main-branch:

⏱ Build time: 1.5 sec (2.74%)

⚖️ Initial size: 0.31 kb (0.01%)

🕵️ Validation errors: 0

Full Statoscope report could be found here ↗️

github-actions · 2025-10-15T10:15:20Z

E2E Tests

Playwright test results

182 passed
5 flaky
2 skipped

Details

189 tests across 105 suites
6 minutes, 17 seconds
e900dbb

Flaky tests

opensource › opensource-suites/connections/clickhouse.test.ts › Clickhouse connector interactions › Connector should be created
opensource › opensource-suites/dash/revisions/revisionsListWithCreationDashboards.test.ts › Dashboards - Versioning › Creating a dashboard, editing, saving as a draft, making the draft version relevant
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Dataset selectors affect each other before applying when auto-update is enabled
opensource › opensource-suites/wizard/fields/parameters.test.ts › Wizard › Fields › The parameterized field should affect the chart
opensource › opensource-suites/wizard/filters/filters-with-dialog-color.test.ts › Wizard filters › Two or more values of the Date field from the dashboard filter section should use IN operation by default

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled

👉 Link with detailed report: report

github-actions · 2025-10-28T14:22:48Z

E2E Tests

Playwright test results

203 passed
9 flaky
2 skipped

Details

214 tests across 116 suites
3 minutes, 25 seconds
b6bc0a9

Flaky tests

opensource › opensource-suites/connections/clickhouse.test.ts › Clickhouse connector interactions › Connector should be created
opensource › opensource-suites/dash/screenshots/widgetsBackground.test.ts › Dashboards - widgets backgrounds screenshots › Title bg color @screenshot
opensource › opensource-suites/dash/screenshots/widgetsBackground.test.ts › Dashboards - widgets backgrounds screenshots › Chart bg color @screenshot
opensource › opensource-suites/wizard/fields/parameters.test.ts › Wizard › Fields › Renaming should not affect the operation of the parameter
opensource › opensource-suites/wizard/visualizations/area/html.test.ts › Wizard › Area chart › Html labels on X axis @screenshot
opensource › opensource-suites/wizard/visualizations/bar-y/data-labels.test.ts › Wizard › Bar-y chart › String dataLabels @screenshot
opensource › opensource-suites/wizard/visualizations/bar-y/sorting.test.ts › Wizard › Bar-y chart › Sorting by X field @screenshot
opensource › opensource-suites/wizard/visualizations/flat-table/export.test.ts › Wizard › Flat table › Export to xlsx
opensource › opensource-suites/wizard/visualizations/pie/hierarchy.test.ts › Wizard › Pie chart › Go to the next level when clicking on a chart with a hierarchy @screenshot

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled

🧐 Links with traces:

👉 Link with detailed report: report

🐳 Link with docker compose logs: logs

Last updated: 2025-12-23 14:25:23 MSK

github-actions · 2025-10-28T14:23:00Z

E2E Tests No Auth

Playwright test results

210 passed
2 flaky
2 skipped

Details

214 tests across 116 suites
3 minutes, 18 seconds
b6bc0a9

Flaky tests

opensource › opensource-suites/wizard/datasets/replace-dataset.test.ts › Wizard › Datasets › Replace dataset
opensource › opensource-suites/wizard/filters/filters-with-dialog-color.test.ts › Wizard filters › Two or more values of the Date field from the dashboard filter section should use IN operation by default

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled

🧐 Links with traces:

👉 Link with detailed report: report

🐳 Link with docker compose logs: logs

Last updated: 2025-12-23 14:25:20 MSK

github-actions · 2025-10-28T14:26:21Z

E2E Tests Farm

Playwright test results

417 passed
8 flaky
1 skipped

Details

426 tests across 171 suites
4 minutes, 18 seconds
13926ab

Flaky tests

basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Wizard with forbidden export › Export menu item is disabled if export is forbidden on connection
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Ql - Export menu item is disabled if export is forbidden on connection
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Required fields validation
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Parameter name validation
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Parameter default_value validation [number]
basic › suites/wizard/colors/coloredByMeasureNames.test.ts › Wizard - section "Colors" › Multidatasets. Fields with the same name should be automatically colored in different colors
basic › suites/wizard/filters/dashboardFilters.test.ts › Wizard - filters › Filters from the URL should be taken into account when saving the chart as images
basic › suites/wizard/metric/metricCustomization.test.ts › Wizard - metric chart. Settings › Size change

Skipped tests

basic › suites/wizard/combined-chart/layers-and-multidatasets.test.ts › Multi-faceted charts with layers › The data on the X-axis must be formed correctly from two datasets

👉 Link with detailed report: report

Last updated: 2025-12-10 18:37:25 MSK

…tions type

…actions, update access dialog translations, and enhance invitation types

…ager.

datalens-weblate-robot · 2025-11-14T10:02:56Z

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

…for collections

datalens-weblate-robot · 2025-11-17T08:20:25Z

i18n-check
Please merge the Pull Request with the changes from Weblate into your branch.

datalens-weblate-robot · 2025-11-20T09:44:15Z

i18n-check

Errors occurred when merging changes from your branch with the Weblate branch.

Rebasing (1/1)
Auto-merging src/i18n-keysets/component.iam-access-dialog/en.json
CONFLICT (content): Merge conflict in src/i18n-keysets/component.iam-access-dialog/en.json
error: could not apply 9b4a581e4... Translated using Weblate (English)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 9b4a581e4... Translated using Weblate (English)
 (1)

Resolve conflicts according to instructions

Switch to the current branch associated with this pull request.

git checkout CHARTS-11939-access-dialog

Add Weblate as remote. And remove previous upstream with the same name:

git remote remove weblate 2> /dev/null
git remote add weblate https://weblate.gravity-ui.com/git/datalens/charts-11939-access-dialog-3022/auth-dialog-change-password-3022/
git -c http.sslVerify=false remote update weblate

Merge Weblate changes:

git merge weblate/CHARTS-11939-access-dialog

Resolve conflicts:

edit ...
git add ...
git commit

Push changes to upstream repository, Weblate will fetch merge from there:

git push origin

imsitnikov · 2025-11-21T19:22:28Z

src/i18n-keysets/component.dialog-switch-public.view/ru.json

  "toast_switch-publication-status-failed": "Не удалось изменить публичный доступ",
-  "toast_switch-publication-status-success": "Публичный доступ был изменен"
+  "toast_switch-publication-status-success": "Публичный доступ был изменен",
+  "label_public-access-warning-title": "Вы даете доступ ко всем выбранным связанным объектам",


There is no code in the opesource repo that uses these keys. Plz add a separate keyset for the new access dialog in the same repo where this keyset are used.

imsitnikov · 2025-11-21T19:31:26Z

src/shared/schema/extensions/actions/organization-manager.ts

+    ResendInvitationRequest,
+} from '../types/invitations';
+
+export const organizationManager = {


Why should we declare these actions in the opensource repo? We don't use them here.

imsitnikov · 2025-11-21T19:41:04Z

src/shared/schema/extensions/types/iam-access-dialog.ts

    federation?: unknown;
    pictureData?: string;
    idpType?: string | null;
+    displayName?: string | React.ReactNode;


SubjectClaims is used in BatchListMembersResponse, which is used by the schema action as return type. How schema action (fetch request) can return React.ReactNode?

If such model creates in UI, the customized type should be placed in the ui folder (even types). Imports from react should not be used in shared.

imsitnikov · 2025-11-21T19:50:04Z

src/ui/registry/units/common/types/functions/onOpenAcceessDialog.ts

@@ -0,0 +1 @@
+export type OpenAccessDialog = (arg: any) => void;


imsitnikov · 2025-11-21T20:09:22Z

src/ui/registry/units/common/types/components/AclSubject.ts


 export type AclSubjectProps = {
    subjectClaims: SubjectClaims;
+    iconSlot?: React.ReactNode;


Is it used somewhere?

imsitnikov · 2025-11-21T20:17:44Z

src/ui/registry/units/common/types/components/AclSubjectSelect.ts

+    avatarData?: string;
+} & Omit<SubjectClaims, 'sub' | 'subType'>;
+
+export interface AclSubjectSelectProps extends Omit<AclSubjectSuggestProps, 'onSubjectChange'> {


This component is not related to opensource repo. Is this declared here only because we don't have its own registry in extensions?

datalens-weblate-robot · 2025-11-27T08:28:58Z

i18n-check

Errors occurred when merging changes from your branch with the Weblate branch.

Rebasing (1/1)
Auto-merging src/i18n-keysets/component.iam-access-dialog/en.json
CONFLICT (content): Merge conflict in src/i18n-keysets/component.iam-access-dialog/en.json
error: could not apply 9b4a581e4... Translated using Weblate (English)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 9b4a581e4... Translated using Weblate (English)
 (1)

Resolve conflicts according to instructions

Switch to the current branch associated with this pull request.

git checkout CHARTS-11939-access-dialog

Add Weblate as remote. And remove previous upstream with the same name:

git remote remove weblate 2> /dev/null
git remote add weblate https://weblate.gravity-ui.com/git/datalens/charts-11939-access-dialog-3022/auth-dialog-change-password-3022/
git -c http.sslVerify=false remote update weblate

Merge Weblate changes:

git merge weblate/CHARTS-11939-access-dialog

Resolve conflicts:

edit ...
git add ...
git commit

Push changes to upstream repository, Weblate will fetch merge from there:

git push origin

datalens-weblate-robot · 2025-11-28T11:37:18Z

i18n-check

Errors occurred when merging changes from your branch with the Weblate branch.

Rebasing (1/1)
Auto-merging src/i18n-keysets/component.iam-access-dialog/en.json
CONFLICT (content): Merge conflict in src/i18n-keysets/component.iam-access-dialog/en.json
error: could not apply 9b4a581e4... Translated using Weblate (English)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 9b4a581e4... Translated using Weblate (English)
 (1)

Resolve conflicts according to instructions

Switch to the current branch associated with this pull request.

git checkout CHARTS-11939-access-dialog

Add Weblate as remote. And remove previous upstream with the same name:

git remote remove weblate 2> /dev/null
git remote add weblate https://weblate.gravity-ui.com/git/datalens/charts-11939-access-dialog-3022/auth-dialog-change-password-3022/
git -c http.sslVerify=false remote update weblate

Merge Weblate changes:

git merge weblate/CHARTS-11939-access-dialog

Resolve conflicts:

edit ...
git add ...
git commit

Push changes to upstream repository, Weblate will fetch merge from there:

git push origin

datalens-weblate-robot · 2025-12-01T07:01:16Z

i18n-check

Errors occurred when merging changes from your branch with the Weblate branch.

Rebasing (1/1)
Auto-merging src/i18n-keysets/component.iam-access-dialog/en.json
CONFLICT (content): Merge conflict in src/i18n-keysets/component.iam-access-dialog/en.json
error: could not apply 9b4a581e4... Translated using Weblate (English)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 9b4a581e4... Translated using Weblate (English)
 (1)

Resolve conflicts according to instructions

Switch to the current branch associated with this pull request.

git checkout CHARTS-11939-access-dialog

Add Weblate as remote. And remove previous upstream with the same name:

git remote remove weblate 2> /dev/null
git remote add weblate https://weblate.gravity-ui.com/git/datalens/charts-11939-access-dialog-3022/auth-dialog-change-password-3022/
git -c http.sslVerify=false remote update weblate

Merge Weblate changes:

git merge weblate/CHARTS-11939-access-dialog

Resolve conflicts:

edit ...
git add ...
git commit

Push changes to upstream repository, Weblate will fetch merge from there:

git push origin

mournfulCoroner · 2025-12-03T12:57:41Z

src/i18n-keysets/component.dialog-switch-public.view/ru.json

  "label_author-description": "При публикации {{subject}} можно указать ссылку на его источник или автора. Ссылка будет отображаться внизу {{subject}}.",
  "label_author-link": "Ссылка",
  "label_author-link-error": "Неверный формат ссылки",
+  "label_author-link-required": "Ссылка обязательна при указании автора",


where is en

mournfulCoroner · 2025-12-03T12:59:44Z

...ui/components/EntryDialogues/DialogSwitchPublic/DialogPublic/AuthorSection/AuthorSection.tsx

-            </div>
-
+            {showWarning && (
+                <>


according to the code style, we use React.Fragment

src/ui/units/collections/components/CollectionContent/hooks/useActions.tsx

mournfulCoroner · 2025-12-03T13:02:11Z

src/shared/schema/extensions/actions/organization-manager.ts

+    ResendInvitationRequest,
+} from '../types/invitations';
+
+export const organizationManager = {


mournfulCoroner · 2025-12-03T13:02:59Z

src/i18n-keysets/component.iam-access-dialog/ru.json

+  "label_delete": "Удалить",
+  "label_to": "Кому",


there is also a lack of en, without this the keys will not work correctly

datalens-weblate-robot · 2025-12-03T21:20:52Z

i18n-check

Errors occurred when merging changes from your branch with the Weblate branch.

Rebasing (1/1)
Auto-merging src/i18n-keysets/component.iam-access-dialog/en.json
CONFLICT (content): Merge conflict in src/i18n-keysets/component.iam-access-dialog/en.json
error: could not apply 9b4a581e4... Translated using Weblate (English)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 9b4a581e4... Translated using Weblate (English)
 (1)

Resolve conflicts according to instructions

Switch to the current branch associated with this pull request.

git checkout CHARTS-11939-access-dialog

Add Weblate as remote. And remove previous upstream with the same name:

git remote remove weblate 2> /dev/null
git remote add weblate https://weblate.gravity-ui.com/git/datalens/charts-11939-access-dialog-3022/auth-dialog-change-password-3022/
git -c http.sslVerify=false remote update weblate

Merge Weblate changes:

git merge weblate/CHARTS-11939-access-dialog

Resolve conflicts:

edit ...
git add ...
git commit

Push changes to upstream repository, Weblate will fetch merge from there:

git push origin

imsitnikov · 2025-12-14T11:31:16Z

src/ui/registry/units/common/types/functions/useSubjectsListId.ts

@@ -1 +1,5 @@
-export type UseSubjectsListId = {type: 'organizationId' | 'cloudId'; id: string | undefined};
+export type UseSubjectsListId = {


This type is used to receive the params needed to retrieve a list of subjects. The title is not required for that. Don't mix logic for different purposes.

…/datalens-ui into CHARTS-11939-access-dialog

imsitnikov · 2025-12-28T11:59:55Z

src/ui/units/collections/components/CollectionContent/hooks/useActions.tsx

-                                        dispatch(closeDialog());
+                        if (isNewAccessDialogEnabled) {
+                            openAccessDialog(dispatch, {
+                                collectionId: item?.collectionId ?? undefined,


item can be optional here?

imsitnikov · 2025-12-28T12:00:10Z

src/ui/units/collections/components/CollectionContent/hooks/useActions.tsx

-                                        dispatch(closeDialog());
+                        if (isNewAccessDialogEnabled) {
+                            openAccessDialog(dispatch, {
+                                workbookId: item?.workbookId ?? undefined,


item can be optional here?

imsitnikov · 2025-12-28T12:02:38Z

src/ui/units/workbooks/components/WorkbookActions/WorkbookActions.tsx

+            openDialog({
+                id: DIALOG_ACCESS,
+                props: {
+                    workbookId: workbook?.workbookId ?? undefined,


workbook can be optional here?

add types

483d6b1

AccessDialog

b9d08a5

YankinA added 2 commits October 30, 2025 12:03

add MultiSelectInputInput

a493146

add access dialog func and component

48a0959

YankinA requested a review from imsitnikov November 5, 2025 14:50

YankinA added 12 commits November 6, 2025 15:15

add new access roles translations

a25d23b

adding renderSubject prop for custom subject rendering

3d903e5

add invite types

ea355a9

refactor organization manager actions and update invitation types

04f2872

add displayName property to SubjectClaims interface and export invita…

efa2dab

…tions type

implement invitation management features including resend and delete …

6c025f5

…actions, update access dialog translations, and enhance invitation types

add EnableNewAccessDialog feature and integrate into useActions

9e5bc17

Merge branch 'main' into CHARTS-11939-access-dialog

48ddffb

Update locale and add updateAccessBindings action to organization man…

e03605e

…ager.

add description invitation sending in IAM access dialog

6b8d805

Add optional iconSlot property to AclSubjectProps type

4153569

Remove MultiSelectInput component

07bcd61

YankinA marked this pull request as ready for review November 14, 2025 09:54

Refactor access dialog handling to support new access dialog feature …

420887a

…for collections

Add new localization keys for author and public access features

6b9def7

imsitnikov requested changes Nov 22, 2025

View reviewed changes

Remove unused OpenAccessDialog type

faeacb8

Remove keys from i18n

cc49287

rename 'canUpdate' to 'canUpdateAccessBindings'

526439a

fix displayName type

b427809

mournfulCoroner reviewed Dec 3, 2025

View reviewed changes

fix after review

e0b06bf

YankinA and others added 8 commits December 10, 2025 10:08

Merge branch 'main' into CHARTS-11939-access-dialog

3594ab3

fix lint

a5d7ffc

Remove unused text

5a31d69

Remove unused translation key from IAM access dialog

3fa9403

Merge branch 'main' into CHARTS-11939-access-dialog

750bd04

remove unused code

9982a00

move invite types to extensions

45a5b48

restore unused componet

13926ab

YankinA requested review from imsitnikov and mournfulCoroner December 11, 2025 07:11

mournfulCoroner previously approved these changes Dec 11, 2025

View reviewed changes

imsitnikov reviewed Dec 14, 2025

View reviewed changes

Add useOrganizationData type and update functions map

b356819

YankinA dismissed mournfulCoroner’s stale review via b356819 December 16, 2025 14:27

YankinA added 3 commits December 18, 2025 20:20

Merge branch 'main' into CHARTS-11939-access-dialog

57c59dc

hide old dialogs from entry menu

7a9eed1

Merge branch 'CHARTS-11939-access-dialog' of github.com:datalens-tech…

b6bc0a9

…/datalens-ui into CHARTS-11939-access-dialog

imsitnikov requested changes Dec 28, 2025

View reviewed changes

YankinA changed the title ~~Workbook access dialog~~ Workbook access dialog legacy Jan 12, 2026

YankinA marked this pull request as draft January 12, 2026 13:21

YankinA added the freeze label Feb 9, 2026

		@@ -0,0 +1 @@
		export type OpenAccessDialog = (arg: any) => void;

		@@ -1 +1,5 @@
		export type UseSubjectsListId = {type: 'organizationId' \| 'cloudId'; id: string \| undefined};
		export type UseSubjectsListId = {

Conversation

YankinA commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 15, 2025

E2E Tests

Playwright test results

Details

Uh oh!

github-actions bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Tests

Playwright test results

Details

Uh oh!

github-actions bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Tests No Auth

Playwright test results

Details

Uh oh!

github-actions bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Tests Farm

Playwright test results

Details

Uh oh!

datalens-weblate-robot commented Nov 14, 2025

Uh oh!

datalens-weblate-robot commented Nov 17, 2025

Uh oh!

datalens-weblate-robot commented Nov 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

datalens-weblate-robot commented Nov 27, 2025

Uh oh!

datalens-weblate-robot commented Nov 28, 2025

Uh oh!

datalens-weblate-robot commented Dec 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

datalens-weblate-robot commented Dec 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

github-actions bot commented Oct 15, 2025 •

edited

Loading

github-actions bot commented Oct 28, 2025 •

edited

Loading

github-actions bot commented Oct 28, 2025 •

edited

Loading

github-actions bot commented Oct 28, 2025 •

edited

Loading