Skip to content

Remove x-dl headers for the external sources#3048

Merged
melikhov-dev merged 1 commit intomainfrom
DLAPI-569
Oct 21, 2025
Merged

Remove x-dl headers for the external sources#3048
melikhov-dev merged 1 commit intomainfrom
DLAPI-569

Conversation

@melikhov-dev
Copy link
Copy Markdown
Collaborator

No description provided.

@melikhov-dev melikhov-dev requested a review from Copilot October 21, 2025 10:42
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the ability to filter out x-dl headers when making requests to external data sources. The change introduces an isExternal flag to identify external sources and prevents internal headers from being forwarded to them.

  • Adds isExternal optional property to SourceConfig type
  • Implements filtering logic to skip x-dl headers for external sources during proxy header processing

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/server/components/charts-engine/types.ts Adds isExternal boolean flag to SourceConfig type
src/server/components/charts-engine/components/processor/data-fetcher.ts Implements header filtering logic to exclude x-dl headers for external sources

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Copy Markdown

📦 Statoscope quick diff with main-branch:

⏱ Build time: -1.4 sec (-2.56%)

⚖️ Initial size: 0.00 kb (0%)

🕵️ Validation errors: 0

Full Statoscope report could be found here ↗️

@github-actions
Copy link
Copy Markdown

E2E Tests

Playwright test results

passed  176 passed
flaky  11 flaky
skipped  2 skipped

Details

stats  189 tests across 105 suites
duration  3 minutes, 36 seconds
commit  657963c

Flaky tests

opensource › opensource-suites/connections/postgres.test.ts › Postgres connector interactions › Client validation errors should be displayed after creation attempt
opensource › opensource-suites/connections/ytsaurus.test.ts › YTsaurus connector interactions › Connector should be created
opensource › opensource-suites/wizard/filters/filters-with-dialog-color.test.ts › Wizard filters › Two or more values of the Date field from the dashboard filter section should use IN operation by default
opensource › opensource-suites/wizard/visualizations/bar-y/grouping.test.ts › Wizard › Bar-y chart › Grouping by Measure Names @screenshot
opensource › opensource-suites/wizard/visualizations/bar-y/sorting.test.ts › Wizard › Bar-y chart › Sorting by X field @screenshot
opensource › opensource-suites/wizard/visualizations/flat-table/virtualization.test.ts › Wizard › Flat table › Dynamic column width during row virtualization @screenshot
opensource › opensource-suites/wizard/visualizations/metric/preview.test.ts › Wizard › Metric chart › Event "chart-preview.done" is triggered after the widget is rendered
opensource › opensource-suites/wizard/visualizations/pie/drag-n-drop.test.ts › Wizard › Pie chart › Add fields by drag-n-drop
opensource › opensource-suites/wizard/visualizations/pivot-table/sorting.test.ts › Wizard › Pivot table › Sorting a row by a field with a parameter
opensource › opensource-suites/wizard/visualizations/treemap/hierarchy.test.ts › Wizard › Treemap chart › Go to the next level when clicking on a chart with a hierarchy @screenshot
opensource › opensource-suites/wizard/visualizations/treemap/html-in-chart.test.ts › Wizard › Treemap chart › Markdown dimension @screenshot

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled


🧐 Links with traces:

👉 Link with detailed report: report

🐳 Link with docker compose logs: logs

Last updated: 2025-10-21 13:49:47 MSK

@github-actions
Copy link
Copy Markdown

E2E Tests Farm

Playwright test results

passed  416 passed
flaky  9 flaky
skipped  1 skipped

Details

stats  426 tests across 171 suites
duration  4 minutes, 30 seconds
commit  657963c

Flaky tests

basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Wizard with forbidden export › Export menu item is disabled if export is forbidden on dataset
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Preview with forbidden export › Wizard preview - Export menu item is disabled if export is forbidden on connection
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Preview with forbidden export › Wizard preview - Export menu item is disabled if export is forbidden on dataset
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Preview with forbidden export › Ql preview - Export menu item is disabled if export is forbidden on connection
basic › suites/dash/revisions/revisionsListWithCreationDashboards.test.ts › Dashboards - Versioning › Creating a dashboard, editing, saving as a draft, making the draft version relevant
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Required fields validation
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Parameter name validation
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Parameter default_value validation [number]
basic › suites/wizard/metric/metricCustomization.test.ts › Wizard - metric chart. Settings › Size change

Skipped tests

basic › suites/wizard/combined-chart/layers-and-multidatasets.test.ts › Multi-faceted charts with layers › The data on the X-axis must be formed correctly from two datasets


👉 Link with detailed report: report

Last updated: 2025-10-21 13:52:10 MSK

@melikhov-dev melikhov-dev merged commit 3e5f9c1 into main Oct 21, 2025
11 checks passed
@melikhov-dev melikhov-dev deleted the DLAPI-569 branch October 21, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants