Skip to content

Fix redux state for s3 based connections #3068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
korvin89 merged 5 commits into from
Oct 28, 2025
Merged

Fix redux state for s3 based connections #3068

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b5bdddd
Fix redux state for s3 based connections
korvin89 Oct 27, 2025
571e400
Do not make request in case of fake entry
korvin89 Oct 27, 2025
971854c
Set revision just in case of revision presence
korvin89 Oct 27, 2025
0b70500
Fix revisions
korvin89 Oct 27, 2025
c5a8de0
Remove setRevision
korvin89 Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/ui/units/connections/components/Page/Page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,10 @@ const PageComponent = (props: PageProps) => {
}, [actions, extractedEntryId, workbookId]);

React.useEffect(() => {
actions.setRevision(revId);
}, [revId, actions]);
if (revisionsSupported) {
actions.setRevision(revId);
}
}, [revId, revisionsSupported, actions]);

const setActualVersion = React.useMemo(
() =>
Expand Down
Loading