Skip to content

Remove react-data-table from dataset preview#3478

Open
arsen-afaunov wants to merge 1 commit intomainfrom
CHARTS-10719-remove-react-data-table-from-dataset-preview
Open

Remove react-data-table from dataset preview#3478
arsen-afaunov wants to merge 1 commit intomainfrom
CHARTS-10719-remove-react-data-table-from-dataset-preview

Conversation

@arsen-afaunov
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

📦 Statoscope quick diff with main-branch:

⏱ Build time: -2.3 sec (-3.97%)

⚖️ Initial size: -0.18 kb (0%)

🕵️ Validation errors: 0

Full Statoscope report could be found here ↗️

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

E2E Tests No Auth

Playwright test results

passed  232 passed
flaky  4 flaky
skipped  2 skipped

Details

stats  238 tests across 127 suites
duration  3 minutes, 24 seconds
commit  4ae4552

Flaky tests

opensource › opensource-suites/wizard/filters/filters-with-dialog-color.test.ts › Wizard filters › Two or more values of the Date field from the dashboard filter section should use IN operation by default
opensource › opensource-suites/wizard/visualizations/bar-y/coloring.test.ts › Wizard › Bar-y chart › Coloring by Measure Values (gradient) @screenshot
opensource › opensource-suites/wizard/visualizations/bar-y/sorting.test.ts › Wizard › Bar-y chart › Sorting by X field @screenshot
opensource › opensource-suites/wizard/visualizations/pivot-table/virtualization.test.ts › Wizard › Pivot table › The correct placement of the totals row @screenshot

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled


🧐 Links with traces:

👉 Link with detailed report: report

🐳 Link with docker compose logs: logs

Last updated: 2026-02-05 15:52:18 MSK

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

E2E Tests

Playwright test results

passed  222 passed
flaky  14 flaky
skipped  2 skipped

Details

stats  238 tests across 127 suites
duration  3 minutes, 46 seconds
commit  4ae4552

Flaky tests

opensource › opensource-suites/connections/clickhouse.test.ts › Clickhouse connector interactions › Client validation errors should be displayed after creation attempt
opensource › opensource-suites/connections/postgres.test.ts › Postgres connector interactions › Connector should be created
opensource › opensource-suites/dash/revisions/revisionsListWithCreationDashboards.test.ts › Dashboards - Versioning › Creating a dashboard, editing, saving as a draft, making the draft version relevant
opensource › opensource-suites/dash/screenshots/widgetsBackground.test.ts › Dashboards - widgets backgrounds screenshots › Chart bg color @screenshot
opensource › opensource-suites/wizard/fields/parameters.test.ts › Wizard › Fields › The parameterized field should affect the chart
opensource › opensource-suites/wizard/visualizations/bar-y/axis-settings.test.ts › Wizard › Bar-y chart › Logarithmic x-axis with zero values @screenshot
opensource › opensource-suites/wizard/visualizations/bar-y/sorting.test.ts › Wizard › Bar-y chart › Sorting by X field @screenshot
opensource › opensource-suites/wizard/visualizations/combined/hierarchies.test.ts › Wizard › Combined chart › When changing the hierarchy in colors, it should be updated on all layers
opensource › opensource-suites/wizard/visualizations/flat-table/pinned-columns.test.ts › Wizard › Flat table › Pinned columns @screenshot
opensource › opensource-suites/wizard/visualizations/flat-table/totals.test.ts › Wizard › Flat table › Totals for different field type
opensource › opensource-suites/wizard/visualizations/line/split.test.ts › Wizard › Line chart › Split with two Y-axes (left and right) @screenshot
opensource › opensource-suites/wizard/visualizations/pivot-table/sorting.test.ts › Wizard › Pivot table › Click on last row header cell should sort columns
opensource › opensource-suites/wizard/visualizations/scatter/coloring.test.ts › Wizard › Scatter chart › Coloring by measure field (gradient) @screenshot
opensource › opensource-suites/wizard/visualizations/treemap/export.test.ts › Wizard › Treemap chart › Export to xlsx

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled


🧐 Links with traces:

👉 Link with detailed report: report

🐳 Link with docker compose logs: logs

Last updated: 2026-02-05 15:53:13 MSK

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

E2E Tests Farm

Playwright test results

passed  411 passed
flaky  10 flaky
skipped  5 skipped

Details

stats  426 tests across 171 suites
duration  4 minutes, 23 seconds
commit  4ae4552

Flaky tests

basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Wizard with forbidden export › Export menu item is disabled if export is forbidden on connection
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Wizard with forbidden export › Export menu item is disabled if export is forbidden on dataset
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Preview with forbidden export › Ql preview - Export menu item is disabled if export is forbidden on connection
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Ql - Export menu item is disabled if export is forbidden on connection
basic › suites/dash/mobile/mobileDash.test.ts › Dashboards - mobile version on Galaxy S8 › The selector is successfully opened by a pop-up component from below
basic › suites/dash/widgets/autoheight.test.ts › Dashboards - Auto-height of widgets › When switching to another widget tab with auto-height, it adjusts without scrolling
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Required fields validation
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Parameter name validation
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Parameter default_value validation [number]
basic › suites/preview/tooltip/customTooltip.test.ts › Preview - Custom tooltip › A custom tooltip is displayed, updated via updateHighChartsConfig in the editor

Skipped tests

basic › suites/charts/inspector/inspector.test.ts › Chart inspector › Clicking on the Inspector menu opens the modal with the rendered time
basic › suites/wizard/chart-settings/navigator.test.ts › Wizard - chartkit › If no lines are selected in the setup, then draws an empty navigator
basic › suites/wizard/combined-chart/layers-and-multidatasets.test.ts › Multi-faceted charts with layers › The data on the X-axis must be formed correctly from two datasets
basic › suites/wizard/sort/sortPlaceholderActions.test.ts › Wizard - Sort › Sorting works if there is a field with the Date type in section X
basic › suites/wizard/sort/sortPlaceholderActions.test.ts › Wizard - Sort › Sorting works if there is a field with the number type in section X, and the same field in the Sorting


👉 Link with detailed report: report

Last updated: 2026-02-05 15:55:57 MSK

@kuzmadom kuzmadom requested a review from korvin89 February 5, 2026 14:07
// Calculate scale factor to handle CSS transforms.
// For very wide tables, Firefox may return incorrect getBoundingClientRect values,
// so we validate that tableScale is within reasonable bounds (0.5 to 2.0)
let tableScale = round(table?.getBoundingClientRect()?.width / table?.clientWidth, 2);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the problem with incorrect calculations in firefox? Perhaps we should consider scale in a different way?
Now, as far as I understand, an incorrect value will be set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants