Skip to content

Remove mode from create-dashboard #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stepanenkoxx merged 3 commits into from
Feb 19, 2026
Merged

Remove mode from create-dashboard #3553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80cab2f
Remove mode from create-dashboard
stepanenkoxx Feb 19, 2026
26ce031
Remove mode from create-dashboard
stepanenkoxx Feb 19, 2026
4b340e5
Fix
stepanenkoxx Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/shared/schema/gateway-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export const createTypedAction = <TOutput, TParams, TTransformed = TOutput>(
) => {
const schemaValidationObject = {
paramsSchema: schema.paramsSchema,
resultSchema: schema.resultSchema,
resultSchema: schema.transformedSchema ?? schema.resultSchema,
};

return registerValidationSchema(actionConfig, schemaValidationObject);
Expand Down
1 change: 0 additions & 1 deletion src/shared/schema/mix/actions/dash/create-dashboard-v1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ export const createDashboardV1 = createTypedAction(
name: argsEntry.name,
meta: argsEntry.meta,
annotation: argsEntry.annotation,
mode: args.mode,
data,
type: '',
scope: EntryScope.Dash,
Expand Down
4 changes: 1 addition & 3 deletions src/shared/schema/mix/schemas/dash/create-dashboard-v1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
import z from 'zod';

import {EntryUpdateMode} from '../../../..';
import {dataSchema} from '../../../../zod-schemas/dash';
import {keyOrWorkbookIdNameSchema} from '../../../../zod-schemas/entry';

import {dashSchemaV1} from './dash-v1';

const createDashData = dataSchema.omit({schemeVersion: true});

export const createDashV1ArgsSchema = z.strictObject({
export const createDashV1ArgsSchema = z.object({
entry: z
.object({
data: createDashData,
Expand All @@ -20,7 +19,6 @@ export const createDashV1ArgsSchema = z.strictObject({
.optional(),
})
.and(keyOrWorkbookIdNameSchema),
mode: z.enum(EntryUpdateMode),
});

export const createDashV1ResultSchema = z.object({
Expand Down
Loading