Add filters to deleteEntry #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanenkoxx
force-pushed
the
DLAPI-500-add-filters-to-delete-entry
branch
from
c937a29 to
9a4cf14
Compare
stepanenkoxx
commented
Sep 16, 2025
| @@ -0,0 +1,7 @@ | |||
| import {z} from 'zod'; | |||
|
|
|||
| export const queryStringArray = () => { | |||
There was a problem hiding this comment.
not the best naming, but I couldn't think of anything
maybe just stringArray?
There was a problem hiding this comment.
GPT offers stringArrayCoerce
but I wouldn't understand that:)
There was a problem hiding this comment.
Let's add min, max options?
jhoncool
reviewed
Sep 16, 2025
| builder.andWhere({[`${Entry.tableName}.${EntryColumn.Scope}`]: scope}); | ||
| } | ||
|
|
||
| if (types) { |
There was a problem hiding this comment.
Is it work good without index on entries.type
I know that we also don't have index on isDeleted but it's boolean
There was a problem hiding this comment.
It makes index scan on entryId and then filters the result, it's 1 row maximum
https://explain.tensor.ru/archive/explain/69ee14e376c7bbf98863ee3c2327e878:0:2025-09-16
jhoncool
previously approved these changes
Sep 17, 2025
jhoncool
reviewed
Sep 17, 2025
| @@ -0,0 +1,118 @@ | |||
| import request from 'supertest'; | |||
There was a problem hiding this comment.
Should we add tests to /env/platform/suites/... also?
stepanenkoxx
force-pushed
the
DLAPI-500-add-filters-to-delete-entry
branch
from
ffb603a to
10c0156
Compare
stepanenkoxx
force-pushed
the
DLAPI-500-add-filters-to-delete-entry
branch
from
33d52d2 to
68d967b
Compare
jhoncool
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datalens-tech/datalens-ui#2629 (comment)