Skip to content

Tweaks to fix up logic and quiet some semgrep warnings. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
datalogics-pgallot wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Tweaks to fix up logic and quiet some semgrep warnings. #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions PermCheck/PermCheck.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,16 +81,10 @@ int main(int argc, char** argv)
if (data != NULL) {
printf("\nStd Security Data Revision: %d\n", data->revision);

// char buffer[33];
// _itoa(data->perms, buffer, 2);
// printf("\nStd Security Data Permission [%d:%s] bits:\n", data->perms, buffer);
char buffer[65] = {};
snprintf(buffer,sizeof(buffer), "\nStd Security Data Permission [0x%x] bits:\n", data->perms);

// non-standard function _itoa replaced with sprintf() for more universal compiler compatibility

char buffer[33];
sprintf(buffer, "\nStd Security Data Permission [%d:%s] bits:\n", data->perms, buffer);

printf("\nStd Security Data Permission [%d:%s] bits:\n", data->perms, buffer);
printf("\n%s\n", buffer);
for (int i = 0; i < LEN(docPerms); i++)
{
bitSet = data->perms & docPerms[i];
Expand All @@ -107,7 +101,7 @@ int main(int argc, char** argv)
for (int i = 0; i < LEN(testObjs); i++)
{
curObj = testObjs[i];
sprintf(szOp, "%s (%d):", objStr[curObj - 1], curObj);
snprintf(szOp,sizeof(szOp), "%s (%d):", objStr[curObj - 1], curObj);
printf("%-15s ", szOp);
}
printf("\n");
Expand All @@ -124,7 +118,7 @@ int main(int argc, char** argv)
curObj = testObjs[i];

status = PDDocPermRequest(pddoc, curObj, curOp, data);
sprintf(szOp, "%s: %s", objStr[curObj - 1], statStr[status + 1]);
snprintf(szOp, sizeof(szOp), "%s: %s", objStr[curObj - 1], statStr[status + 1]);
printf("%-15s ", szOp);
}
printf("\n");
Expand Down