SF46895 - Limit char quad matching. #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QA noticed for a particular document viewing it caused an out of bounds exception. This is a legacy viewer sample which had a lot of things crammed into it. In this case text highlighting isn't quite handling unicode correctly but we have dedicated Text samples for showing how to work with the WordFinder so let's just make sure the text size and # of quads match up to prevent this problem from happening.
datalogics-rgailiunas
approved these changes
Apr 18, 2025
datalogics-rgailiunas
merged commit 35012c4
into
datalogics:develop
7 of 89 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA noticed for a particular document viewing it caused an out of bounds exception.
This is a legacy viewer sample which had a lot of things crammed into it. In this case text highlighting isn't quite handling unicode correctly but we have dedicated Text samples for showing how to work with the WordFinder so let's just make sure the text size and # of quads match up to prevent this problem from happening.