Fix type for flush promise return value: Boolean -> boolean#47
Merged
nblumhardt merged 1 commit intodatalust:devfrom Sep 12, 2025
Merged
Fix type for flush promise return value: Boolean -> boolean#47nblumhardt merged 1 commit intodatalust:devfrom
nblumhardt merged 1 commit intodatalust:devfrom
Conversation
In TypeScript, there is a crucial distinction between boolean (lowercase) and Boolean (uppercase). boolean (lowercase): This refers to the primitive boolean type in TypeScript and JavaScript. It represents a simple true or false value. This is the type that should be used almost exclusively when declaring variables, function parameters, or return types in TypeScript. Boolean (uppercase): This refers to the JavaScript Boolean object wrapper. While it can also hold a true or false value, it is an object, not a primitive. Using Boolean objects can lead to unexpected behavior due to JavaScript's type coercion rules, where an object (even a Boolean object wrapping false) is considered "truthy" in a boolean context.
Member
|
Nice spotting - thanks 👍 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In TypeScript, there is a crucial distinction between boolean (lowercase) and Boolean (uppercase).
boolean (lowercase): This refers to the primitive boolean type in TypeScript and JavaScript. It represents a simple true or false value. This is the type that should be used almost exclusively when declaring variables, function parameters, or return types in TypeScript.
Boolean (uppercase): This refers to the JavaScript Boolean object wrapper. While it can also hold a true or false value, it is an object, not a primitive. Using Boolean objects can lead to unexpected behavior due to JavaScript's type coercion rules, where an object (even a Boolean object wrapping false) is considered "truthy" in a boolean context.