Adding the gcc, gxx, pybind to the env file. Preparing for packaging#527
Closed
DomInvivo wants to merge 1 commit intographium_3.0from
Closed
Adding the gcc, gxx, pybind to the env file. Preparing for packaging#527DomInvivo wants to merge 1 commit intographium_3.0from
DomInvivo wants to merge 1 commit intographium_3.0from
Conversation
Collaborator
Author
|
@Andrewq11 , are you working on that branch? I assume you have your own branch for this, and we can close this one |
Collaborator
|
Yes I have my own branch for the packaging work. Feel free to close this. |
Collaborator
|
Closing PR as work has evolved on another branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelogs
env.ymlfile to contain all the gcc requirementsIssues to resolve:
gccandgxxdo not work in the env file, we need to specifygcc_linux-64andgxx_linux-64. Ideally, we want to support Win64, WinARM, Linux64, LinuxARM, Mac64, MacARMgcc --versionandgxx --versiondon't appear in the command line. We need to rename their foldersln -s MY_ENV_PATH/bin/x86_64-conda-linux-gnu-gcc MY_ENV_PATH/bin/gcc, same withgxx.graphium/graphium_cppseparately withpybind11, then install it withpip install -e graphium_cpp --no-deps. Ideally, all should be built and installed from directlypip install -e . --no-deps.