Get-SqlDatabase accepts Workspace as a pipeline and handles errors correctly#118
Get-SqlDatabase accepts Workspace as a pipeline and handles errors correctly#118
Conversation
Linux Test Results4 568 tests 4 567 ✅ 42s ⏱️ Results for commit 768bc5f. |
WinPS51 Test Results4 773 tests 4 772 ✅ 51s ⏱️ Results for commit 768bc5f. |
WinPS71 Test Results4 773 tests 4 772 ✅ 50s ⏱️ Results for commit 768bc5f. |
|
Hey @NowinskiK Partly my fault, I didn't press the submit review button on this - but I don't think this PR got an approval before being merged? |
| - Added credits for authors to all functions and Unit tests to verify the existence of such tags #89 | ||
|
|
||
| ### Changed | ||
| - Get-SqlDatabase accepts Workspace as a pipeline, handles errors correctly and can filter by name (#117). |
There was a problem hiding this comment.
Should this be Get-FabricSqlDatabase?
There was a problem hiding this comment.
Yes! You are absolutely right! I missed it :) Good spot, thanks!!! I will fix it soon.
No worries at all, Jess. There is no one fault here! I assumed that these changes are small & low risk, hence I decided to merge them. We are at the early stage of the project, so I want to keep the momentum. This happened before and I don't blame anyone as we all know well what we are doing here (I still believe that bigger changes even now should go via full review). |


Pull Request
Pull Request (PR) description
Changed
Task list
build.ps1 -ResolveDependency -Tasks build, test).