Skip to content

Get-SqlDatabase accepts Workspace as a pipeline and handles errors correctly#118

Merged
NowinskiK merged 5 commits intodevelopfrom
sqldatabase
Jun 13, 2025
Merged

Get-SqlDatabase accepts Workspace as a pipeline and handles errors correctly#118
NowinskiK merged 5 commits intodevelopfrom
sqldatabase

Conversation

@NowinskiK
Copy link
Contributor

@NowinskiK NowinskiK commented Jun 11, 2025

Pull Request

Pull Request (PR) description

Changed

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency -Tasks build, test).
  • Comment-based help added/updated.
  • Examples appropriately added/updated.
  • Unit tests added/updated..
  • Integration tests added/updated (where possible).
  • Documentation added/updated (where applicable).
  • Code follows the contribution guidelines.

@NowinskiK NowinskiK linked an issue Jun 11, 2025 that may be closed by this pull request
@NowinskiK NowinskiK marked this pull request as ready for review June 11, 2025 16:27
@github-actions
Copy link

Linux Test Results

4 568 tests   4 567 ✅  42s ⏱️
  405 suites      1 💤
    1 files        0 ❌

Results for commit 768bc5f.

@github-actions
Copy link

WinPS51 Test Results

4 773 tests   4 772 ✅  51s ⏱️
  406 suites      1 💤
    1 files        0 ❌

Results for commit 768bc5f.

@github-actions
Copy link

WinPS71 Test Results

4 773 tests   4 772 ✅  50s ⏱️
  406 suites      1 💤
    1 files        0 ❌

Results for commit 768bc5f.

@NowinskiK NowinskiK merged commit 40a4004 into develop Jun 13, 2025
8 checks passed
@jpomfret
Copy link
Contributor

Hey @NowinskiK

Partly my fault, I didn't press the submit review button on this - but I don't think this PR got an approval before being merged?

image

- Added credits for authors to all functions and Unit tests to verify the existence of such tags #89

### Changed
- Get-SqlDatabase accepts Workspace as a pipeline, handles errors correctly and can filter by name (#117).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Get-FabricSqlDatabase?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! You are absolutely right! I missed it :) Good spot, thanks!!! I will fix it soon.

@NowinskiK
Copy link
Contributor Author

Hey @NowinskiK

Partly my fault, I didn't press the submit review button on this - but I don't think this PR got an approval before being merged?

image

No worries at all, Jess. There is no one fault here! I assumed that these changes are small & low risk, hence I decided to merge them. We are at the early stage of the project, so I want to keep the momentum. This happened before and I don't blame anyone as we all know well what we are doing here (I still believe that bigger changes even now should go via full review).

@SQLDBAWithABeard SQLDBAWithABeard deleted the sqldatabase branch June 14, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get-SqlDatabase accepts pipelines & handle errors

2 participants