Feature/small updates by SQLDBAWithABeard · Pull Request #122 · dataplat/FabricTools

SQLDBAWithABeard · 2025-06-14T10:01:12Z

Pull Request

Pull Request (PR) description

updating the help to remove backticks
Improving the exit of the incompatible parameters so that there is no red error.
Adding end block as required by begin and process to return details from multiple objects in preparation for improving the output and making it more user friendly

Task list

[ X] The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
[ X] Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
[X ] Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency -Tasks build, test).
[ X] Comment-based help added/updated.
[ X] Examples appropriately added/updated.
[X ] Unit tests added/updated..
Integration tests added/updated (where possible).
Documentation added/updated (where applicable).
Code follows the contribution guidelines.

Corrected the function name from Get-SqlDatabase to Get-FabricSqlDatabase in the CHANGELOG. Updated examples in the Get-FabricSQLDatabase function to improve clarity and consistency. Thank you!

Refactor the function to return warnings instead of throwing errors when both SQLDatabaseName and SQLDatabaseId are provided. Update the synopsis and description for clarity. Ensure the return value is correctly handled in the End block. Thank you!

github-actions · 2025-06-14T10:04:48Z

Linux Test Results

4 568 tests 4 567 ✅ 41s ⏱️
405 suites 1 💤
1 files 0 ❌

Results for commit 286d251.

♻️ This comment has been updated with latest results.

github-actions · 2025-06-14T10:04:54Z

WinPS51 Test Results

4 773 tests 4 772 ✅ 50s ⏱️
406 suites 1 💤
1 files 0 ❌

Results for commit 286d251.

♻️ This comment has been updated with latest results.

github-actions · 2025-06-14T10:05:00Z

WinPS71 Test Results

4 773 tests 4 772 ✅ 50s ⏱️
406 suites 1 💤
1 files 0 ❌

Results for commit 286d251.

♻️ This comment has been updated with latest results.

jpomfret

lgtm

NowinskiK

I left a few small comments. Thanks!

source/Public/SQL Database/Get-FabricSQLDatabase.ps1

Clarify the function's synopsis and description to enhance understanding. Corrected the spelling of "examples" and updated the URI to follow the correct casing for SQL databases. Thank you!

source/Public/SQL Database/Get-FabricSQLDatabase.ps1

Changed the example command to use quotes around the workspace name for consistency and clarity. This helps users understand the correct syntax when using the function. Thank you!

Changed the workspace name in the example to 'MsLearn-dev' because thats important Thank you!

source/Public/SQL Database/Get-FabricSQLDatabase.ps1

This change restructures the function to ensure that the SQLDatabaseName and SQLDatabaseID parameters cannot be used together, enhancing the clarity of parameter usage. The process block has been properly defined to maintain code organization and readability. Thank you!

Reorganize function structure and enhance code clarity by adjusting the formatting of the function definition and control structures. This change aims to make the code more maintainable and easier to understand. Thank you!

SQLDBAWithABeard · 2025-06-15T14:03:43Z

I have reverted back to the validation as you had it so please have a look and see if you can find anything else

NowinskiK · 2025-06-15T19:37:41Z

When testing the function I found one error:

Get-FabricWorkspace | where { $_.displayName -like 'mslearn-*' } | Get-FabricSQLDatabase -SQLDatabaseName 'AdventureWorksLT_dev'

SQLDBAWithABeard · 2025-06-15T19:56:19Z

HO

When testing the function I found one error:

Get-FabricWorkspace | where { $_.displayName -like 'mslearn-*' } | Get-FabricSQLDatabase -SQLDatabaseName 'AdventureWorksLT_dev'

I cant reproduce this with this branch as you can see in my images

even though I have multiple workspaces

PS > get-fabricWorkspace | Where displayName -like 'blog*'

id          : 9e52da3e-8c56-42dd-ad44-d4452114c0b3
displayName : BlogPostWorkspace
description : A workspace for a blog post
type        : Workspace
capacityId  : 53e1c034-d719-443e-be93-188f10f8dcca

id          : b5db4f9a-3513-4dd0-8eb7-bbe662058c65
displayName : blog1
description :
type        : Workspace

Each Workspace has a Fabric SQL Database even putting the name of the database does not lead to an error here

what is returned from

Get-FabricWorkspace | where { $_.displayName -like 'mslearn-*' }

Please can you provide some more details.

Confirm that you are on the correct branch
Have built in a new clean session
Which version of PoweShell you are using

If you still get the error please can you post all of the code that you entered since the session started with

Get-History | scb

and also the results of

Get-Error -Newest 5 | scb

This change introduces an initialization of the return array at the beginning of the Get-FabricSQLDatabase function. This will ensure that the function has a defined return structure, improving its reliability and maintainability. Thank you!

NowinskiK · 2025-06-15T20:24:56Z

Yes, branch is ok - feature/small-updates. I have code in VSCode because it was easier to review the whole function after the changes.
I always build the module.

Get-FabricWorkspace -WorkspaceName 'mslearn-dev'

It works without providing SQLDatabaseName:
Get-FabricWorkspace -WorkspaceName 'mslearn-dev' | Get-FabricSQLDatabase

I think it happens when one of the workspaces does not have any databases. Please check that.

SQLDBAWithABeard · 2025-06-15T20:31:19Z

Yes, branch is ok - feature/small-updates. I have code in VSCode because it was easier to review the whole function after the changes. I always build the module.

Get-FabricWorkspace -WorkspaceName 'mslearn-dev'

It works without providing SQLDatabaseName: Get-FabricWorkspace -WorkspaceName 'mslearn-dev' | Get-FabricSQLDatabase

I think it happens when one of the workspaces does not have any databases. Please check that.

Thats interesting.

Did you have the results of the get-error?
and the code you ran

NowinskiK

It works now! Good job! Thanks!

This change ensures that the return array is only updated if there is a valid response from the SQLDatabase filtering. This prevents potential errors when no matching databases are found. Thank you!

SQLDBAWithABeard · 2025-06-15T20:33:13Z

Resolved with some validation

SQLDBAWithABeard added 2 commits June 14, 2025 10:16

Fix function name in CHANGELOG and update examples

5c8740b

Corrected the function name from Get-SqlDatabase to Get-FabricSqlDatabase in the CHANGELOG. Updated examples in the Get-FabricSQLDatabase function to improve clarity and consistency. Thank you!

SQLDBAWithABeard requested a review from NowinskiK June 14, 2025 10:01

jpomfret approved these changes Jun 14, 2025

View reviewed changes

NowinskiK requested changes Jun 14, 2025

View reviewed changes

Update Get-FabricSQLDatabase documentation and URI

398181f

Clarify the function's synopsis and description to enhance understanding. Corrected the spelling of "examples" and updated the URI to follow the correct casing for SQL databases. Thank you!

NowinskiK requested changes Jun 14, 2025

View reviewed changes

source/Public/SQL Database/Get-FabricSQLDatabase.ps1 Outdated Show resolved Hide resolved

SQLDBAWithABeard added 2 commits June 14, 2025 17:04

Update example in Get-FabricSQLDatabase documentation

5b7294c

Changed the example command to use quotes around the workspace name for consistency and clarity. This helps users understand the correct syntax when using the function. Thank you!

Update example in Get-FabricSQLDatabase documentation

1912274

Changed the workspace name in the example to 'MsLearn-dev' because thats important Thank you!

NowinskiK requested changes Jun 15, 2025

View reviewed changes

source/Public/SQL Database/Get-FabricSQLDatabase.ps1 Outdated Show resolved Hide resolved

SQLDBAWithABeard added 2 commits June 15, 2025 14:47

Refactor Get-FabricSQLDatabase for improved readability

d7c577e

Reorganize function structure and enhance code clarity by adjusting the formatting of the function definition and control structures. This change aims to make the code more maintainable and easier to understand. Thank you!

NowinskiK approved these changes Jun 15, 2025

View reviewed changes

Add check for response before updating return array

286d251

This change ensures that the return array is only updated if there is a valid response from the SQLDatabase filtering. This prevents potential errors when no matching databases are found. Thank you!

NowinskiK approved these changes Jun 15, 2025

View reviewed changes

SQLDBAWithABeard merged commit c7f0638 into develop Jun 16, 2025
8 checks passed

Conversation

SQLDBAWithABeard commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request

Pull Request (PR) description

Task list

Uh oh!

github-actions bot commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Linux Test Results

Uh oh!

github-actions bot commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WinPS51 Test Results

Uh oh!

github-actions bot commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WinPS71 Test Results

Uh oh!

jpomfret left a comment

Choose a reason for hiding this comment

Uh oh!

NowinskiK left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SQLDBAWithABeard commented Jun 15, 2025

Uh oh!

NowinskiK commented Jun 15, 2025

Uh oh!

SQLDBAWithABeard commented Jun 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NowinskiK commented Jun 15, 2025

Uh oh!

SQLDBAWithABeard commented Jun 15, 2025

Uh oh!

NowinskiK left a comment

Choose a reason for hiding this comment

Uh oh!

SQLDBAWithABeard commented Jun 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SQLDBAWithABeard commented Jun 14, 2025 •

edited

Loading

github-actions bot commented Jun 14, 2025 •

edited

Loading

github-actions bot commented Jun 14, 2025 •

edited

Loading

github-actions bot commented Jun 14, 2025 •

edited

Loading

SQLDBAWithABeard commented Jun 15, 2025 •

edited

Loading