Write-Message should use Write-Warning & Write-Error when needed #136#147
Merged
Write-Message should use Write-Warning & Write-Error when needed #136#147
Conversation
9 tasks
Linux Test Results5 102 tests 5 101 ✅ 45s ⏱️ Results for commit a581a23. ♻️ This comment has been updated with latest results. |
WinPS51 Test Results5 316 tests 5 315 ✅ 50s ⏱️ Results for commit a581a23. ♻️ This comment has been updated with latest results. |
WinPS71 Test Results5 316 tests 5 315 ✅ 46s ⏱️ Results for commit a581a23. ♻️ This comment has been updated with latest results. |
Contributor
tiagobalabuch
left a comment
There was a problem hiding this comment.
It looks like good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
This is a simple change and adoption of a well-known PS functions
Write-Warning&Write-Errorin private wrapper functionWrite-Message.There is one comment/question for like "Critical", but I guess this may come under #84.
Pull Request (PR) description
Changed
Write-MessageusesWrite-Warning&Write-Errorwhen needed - closesWrite-Messagedoes not respect$WarningActionPreferenceor$ErrorActionPreference#136Task list
build.ps1 -ResolveDependency -Tasks build, test).