Skip to content

Write-Message should use Write-Warning & Write-Error when needed #136#147

Merged
NowinskiK merged 3 commits intodevelopfrom
feature/136-write-message
Jul 11, 2025
Merged

Write-Message should use Write-Warning & Write-Error when needed #136#147
NowinskiK merged 3 commits intodevelopfrom
feature/136-write-message

Conversation

@NowinskiK
Copy link
Contributor

@NowinskiK NowinskiK commented Jul 8, 2025

Pull Request

This is a simple change and adoption of a well-known PS functions Write-Warning & Write-Error in private wrapper function Write-Message.
There is one comment/question for like "Critical", but I guess this may come under #84.

Pull Request (PR) description

Changed

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency -Tasks build, test).
  • Comment-based help added/updated.
  • Examples appropriately added/updated.
  • Unit tests added/updated..
  • Integration tests added/updated (where possible).
  • Documentation added/updated (where applicable).
  • Code follows the contribution guidelines.

@github-actions
Copy link

github-actions bot commented Jul 10, 2025

Linux Test Results

5 102 tests   5 101 ✅  45s ⏱️
  619 suites      1 💤
    1 files        0 ❌

Results for commit a581a23.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 10, 2025

WinPS51 Test Results

5 316 tests   5 315 ✅  50s ⏱️
  620 suites      1 💤
    1 files        0 ❌

Results for commit a581a23.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 10, 2025

WinPS71 Test Results

5 316 tests   5 315 ✅  46s ⏱️
  620 suites      1 💤
    1 files        0 ❌

Results for commit a581a23.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@tiagobalabuch tiagobalabuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like good.

@tiagobalabuch tiagobalabuch self-requested a review July 11, 2025 17:04
Copy link
Contributor

@tiagobalabuch tiagobalabuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@NowinskiK NowinskiK merged commit 0abbd41 into develop Jul 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write-Message does not respect $WarningActionPreference or $ErrorActionPreference

2 participants