Skip to content

Conversation

NowinskiK
Copy link
Contributor

@NowinskiK NowinskiK commented Jul 12, 2025

Pull Request

This PR addresses the following issues (they are all related to each other, so they had to be changed in the same branch):

Pull Request (PR) description

Added

Changed

  • Internal function Invoke-FabricRestMethod: (Combine Invoke-FabricRestMethod and Test-FabricApiResponse #143)
    • handles API response, no need to use Test-FabricApiResponse from parent public function
    • handles pagination automatically (when -HandleResponse is provided)
  • All Deployment Pipeline functions raise an error when an exception is caught. Used splatting for params.
  • Refactored SQL Database functions to use enhanced capability in Invoke-FabricRestMethod. Used splatting for params.
  • Write-Message uses PSFramework function for logging, which logs function name (Use PSFramework for logging #84)

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency -Tasks build, test).
  • Comment-based help added/updated.
  • Examples appropriately added/updated.
  • Unit tests added/updated..
  • Integration tests added/updated (where possible).
  • Documentation added/updated (where applicable).
  • Code follows the contribution guidelines.

Copy link

github-actions bot commented Jul 12, 2025

Linux Test Results

5 085 tests   5 084 ✅  46s ⏱️
  617 suites      1 💤
    1 files        0 ❌

Results for commit 9516b81.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 12, 2025

WinPS51 Test Results

5 298 tests   5 297 ✅  46s ⏱️
  618 suites      1 💤
    1 files        0 ❌

Results for commit 9516b81.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 12, 2025

WinPS71 Test Results

5 298 tests   5 297 ✅  47s ⏱️
  618 suites      1 💤
    1 files        0 ❌

Results for commit 9516b81.

♻️ This comment has been updated with latest results.

@NowinskiK NowinskiK marked this pull request as ready for review July 13, 2025 21:29
Copy link
Contributor

@tiagobalabuch tiagobalabuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

@NowinskiK NowinskiK merged commit 1218924 into develop Jul 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants