Conversation
…y removing the unnecessary module import. This change helps avoid issues with loading dependencies during testing.
lets run some tests on PR
This change simplifies the workflow configuration by removing the unnecessary 'testBranch' entry. This helps maintain clarity and focus on the relevant branches for testing. Thank you!
Linux Test Results1 268 tests 935 ✅ 33s ⏱️ For more details on these failures, see this check. Results for commit f04f593. ♻️ This comment has been updated with latest results. |
WinPS51 Test Results1 268 tests 935 ✅ 40s ⏱️ For more details on these failures, see this check. Results for commit f04f593. ♻️ This comment has been updated with latest results. |
WinPS71 Test Results1 268 tests 935 ✅ 43s ⏱️ For more details on these failures, see this check. Results for commit f04f593. ♻️ This comment has been updated with latest results. |
|
I mean, it’s obvious we can’t approve these changes. LOOK AT ALL THOSE FAILING TESTS LOL On a serious note. THANKYOU @jpomfret This is amazing and another step towards some fantastic collaboration automation. You rock |
|
It's a party 🎊 |
|
@SQLDBAWithABeard @NowinskiK any objections if we merge this into sampler? Then we should get updates on that branch for how many tests are left to fix. I'm going to look at adding some basic unit tests like we have in dbatools for parameters, etc. |
|
Yep let's merge. |
|
This looks amazing, thanks @jpomfret !!! Sorry, I've been away the whole day. |
3 participants
Let's run all the tests on PRs so we can see we're getting closer to ✅ and in the future if folks submit PRs we know they pass the tests.
For your review folks: @NowinskiK, @Frank-Geisler, @tiagobalabuch, @Jojobit, @SQLDBAWithABeard