Conversation
…spaceName parameter to allow additional special characters. This change enhances flexibility in naming workspaces while maintaining validation integrity.
Linux Test Results4 612 tests 4 611 ✅ 41s ⏱️ Results for commit 4c6c0e2. ♻️ This comment has been updated with latest results. |
WinPS51 Test Results4 612 tests 4 611 ✅ 53s ⏱️ Results for commit 4c6c0e2. ♻️ This comment has been updated with latest results. |
WinPS71 Test Results4 612 tests 4 611 ✅ 53s ⏱️ Results for commit 4c6c0e2. ♻️ This comment has been updated with latest results. |
jpomfret
reviewed
May 23, 2025
Contributor
|
@Jojobit - I don't think there are restrictions on naming workspace - so wondering if we're better just dropping the validation from the names on this and the other workspace commands? thoughts? (NOTE: didn't read your reply before I wrote this - we're on the same page 🤣🤣) |
…lidation for the WorkspaceName parameter, allowing for greater flexibility in naming workspaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close Current workspace name validation too restrictive, doesn't allow common characters #57