Skip to content

Add Service Principal parameters for authentication#76

Merged
jpomfret merged 9 commits intodevelopfrom
connectFabricSP
May 27, 2025
Merged

Add Service Principal parameters for authentication#76
jpomfret merged 9 commits intodevelopfrom
connectFabricSP

Conversation

@Jojobit
Copy link
Contributor

@Jojobit Jojobit commented May 26, 2025

Enhanced the Connect-FabricAccount function by adding support for Service Principal authentication. This includes new parameters for ServicePrincipalId, ServicePrincipalSecret, and Credential, allowing for more flexible authentication options. Updated the unit tests to reflect these changes and ensure proper validation.

Thank you!

Pull Request

Added

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@Jojobit
Add Service Principal parameters for authentication
2b6a1bc 
Enhanced the Connect-FabricAccount function by adding support for Service Principal authentication. This includes new parameters for ServicePrincipalId, ServicePrincipalSecret, and Credential, allowing for more flexible authentication options. Updated the unit tests to reflect these changes and ensure proper validation.

Thank you!
@github-actions
Copy link

github-actions bot commented May 26, 2025 •
edited
Loading

Linux Test Results

4 617 tests   4 616 ✅  43s ⏱️
  410 suites      1 💤
    1 files        0 ❌

Results for commit bdc0836.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 26, 2025 •
edited
Loading

WinPS51 Test Results

4 617 tests   4 616 ✅  55s ⏱️
  410 suites      1 💤
    1 files        0 ❌

Results for commit bdc0836.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 26, 2025 •
edited
Loading

WinPS71 Test Results

4 617 tests   4 616 ✅  51s ⏱️
  410 suites      1 💤
    1 files        0 ❌

Results for commit bdc0836.

♻️ This comment has been updated with latest results.

@Jojobit
Copy link
Contributor Author

Jojobit commented May 27, 2025

@jpomfret @SQLDBAWithABeard can you help me with a PR approval?

jpomfret
jpomfret reviewed May 27, 2025
View reviewed changes
jpomfret
jpomfret reviewed May 27, 2025
View reviewed changes
SQLDBAWithABeard
SQLDBAWithABeard requested changes May 27, 2025
View reviewed changes
jpomfret
jpomfret reviewed May 27, 2025
View reviewed changes
jpomfret
jpomfret reviewed May 27, 2025
View reviewed changes
jpomfret
jpomfret reviewed May 27, 2025
View reviewed changes
@jpomfret
Copy link
Contributor

jpomfret commented May 27, 2025

@Jojobit - yeah!! Nice add 🙂 - added a couple of comments, where possible I made suggestions so should make it easy for you to add them in if you're happy

Jojobit and others added 4 commits May 27, 2025 11:22
@Jojobit @jpomfret
Update Connect-FabricAccount.ps1
846df1e 
Co-authored-by: Jess Pomfret <jpomfret7@gmail.com>
Signed-off-by: Ioana Bouariu <100302417+Jojobit@users.noreply.github.com>
@Jojobit @jpomfret
Update Connect-FabricAccount.ps1
41628ac 
Co-authored-by: Jess Pomfret <jpomfret7@gmail.com>
Signed-off-by: Ioana Bouariu <100302417+Jojobit@users.noreply.github.com>
@Jojobit @jpomfret
Update Connect-FabricAccount.ps1
0b78c95 
Co-authored-by: Jess Pomfret <jpomfret7@gmail.com>
Signed-off-by: Ioana Bouariu <100302417+Jojobit@users.noreply.github.com>
@Jojobit @jpomfret
Update Connect-FabricAccount.ps1
3b535d6 
Co-authored-by: Jess Pomfret <jpomfret7@gmail.com>
Signed-off-by: Ioana Bouariu <100302417+Jojobit@users.noreply.github.com>
SQLDBAWithABeard
SQLDBAWithABeard reviewed May 27, 2025
View reviewed changes
@SQLDBAWithABeard
Copy link
Contributor

SQLDBAWithABeard commented May 27, 2025

Happy to make the changes for you @Jojobit - If you would like.

Thank you, this is awesome, so good to see all of your hard work coming to fruition here and thank you for creating the first PR of the next round !!

@Jojobit
Copy link
Contributor Author

Jojobit commented May 27, 2025

@jpomfret @SQLDBAWithABeard feel free

@SQLDBAWithABeard
So that we have good practice and resolve PR comments
ed1ff29 
Signed-off-by: Rob Sewell <mrrobsewell@outlook.com>
@SQLDBAWithABeard
Updating the examples
7638464 
Signed-off-by: Rob Sewell <mrrobsewell@outlook.com>
@SQLDBAWithABeard
Updating should process
64b03a2 
Signed-off-by: Rob Sewell <mrrobsewell@outlook.com>
@SQLDBAWithABeard
Because I didnt edit in vscode where the whitespace would be removed
bdc0836 
Signed-off-by: Rob Sewell <mrrobsewell@outlook.com>
@jpomfret jpomfret merged commit 2a7adde into develop May 27, 2025
8 checks passed
@SQLDBAWithABeard SQLDBAWithABeard deleted the connectFabricSP branch June 2, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpomfret jpomfret jpomfret approved these changes

@SQLDBAWithABeard SQLDBAWithABeard SQLDBAWithABeard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Authentication needs to support ServicePrincipal

3 participants

@Jojobit @jpomfret @SQLDBAWithABeard