InvalidJobOwner

Author: ClaudioESSilva

source/checks/Agentv5.Tests.ps1

@@ -130,6 +130,23 @@ Describe "Valid Job Owner" -Tag ValidJobOwner, Agent -ForEach $InstancesToTest {
 }
 
 
+Describe "Invalid Job Owner" -Tag InvalidJobOwner, Agent -ForEach $InstancesToTest {
+    $skipAgentJobTargetInvalidOwner = ($__dbcconfig | Where-Object { $_.Name -eq 'skip.agent.invalidjobowner.name' }).Value
+
+    Context "Testing Invalid SQL Agent Job Owner on <_.Name>" {
+        It "The Job <_.JobName> has the Job Owner <_.ActualJobOwnerName> that shouldn't exist in this list ($([String]::Join(', ', "<_.InvalidJobOwnerName>"))) on <_.InstanceName>" -Skip:$skipAgentJobTargetOwner -ForEach ($PSItem.InvalidJobOwner) {
+            $PSItem.ActualJobOwnerName | Should -Not -BeIn $PSItem.InvalidJobOwnerName -Because 'The account that is the job owner has been defined as not valid'
+        }
+    }
+}
+
+
+
+
+
+
+
+
 
 
 # Describe "Failed Jobs" -Tags FailedJob, $filename {
@@ -167,26 +184,6 @@ Describe "Valid Job Owner" -Tag ValidJobOwner, Agent -ForEach $InstancesToTest {
 #     }
 # }
 
-# Describe "Invalid Job Owner" -Tags InValidJobOwner, $filename {
-#     [string[]]$targetowner = Get-DbcConfigValue agent.invalidjobowner.name
-
-#     if ($NotContactable -contains $psitem) {
-#         Context "Testing job owners on $psitem" {
-#             It "Can't Connect to $Psitem" {
-#                 $false | Should -BeTrue -Because "The instance should be available to be connected to!"
-#             }
-#         }
-#     }
-#     else {
-#         Context "Testing job owners on $psitem" {
-#             @(Get-DbaAgentJob -SqlInstance $psitem -EnableException:$false).ForEach{
-#                 It "Job $($psitem.Name)  - owner $($psitem.OwnerLoginName) should not be in this list ( $( [String]::Join(", ", $targetowner) ) ) on $($psitem.SqlInstance)" {
-#                     $psitem.OwnerLoginName | Should -Not -BeIn $TargetOwner -Because "The account that is the job owner has been defined as not valid"
-#                 }
-#             }
-#         }
-#     }
-# }
 
 # Describe "Agent Alerts" -Tags AgentAlert, $filename {
 #     $severity = Get-DbcConfigValue agent.alert.Severity

source/internal/configurations/configuration.ps1

@@ -346,6 +346,7 @@ Set-PSFConfig -Module dbachecks -Name skip.agent.mailprofile -Validation bool -V
 Set-PSFConfig -Module dbachecks -Name skip.agent.longrunningjobs -Validation bool -Value $false -Initialize -Description "Skip the long running agent jobs check"
 Set-PSFConfig -Module dbachecks -Name skip.agent.lastjobruntime -Validation bool -Value $false -Initialize -Description "Skip the last agent job time check"
 Set-PSFConfig -Module dbachecks -Name skip.agent.jobowner -Validation bool -Value $false -Initialize -Description "Skip the Agent Job Owner check"
+Set-PSFConfig -Module dbachecks -Name skip.agent.invalidjobowner.name -Validation bool -Value $false -Initialize -Description "Skip the Agent Job Invalid Owner check"
 
 
 

source/internal/functions/Get-AllAgentInfo.ps1

@@ -38,6 +38,9 @@ function Get-AllAgentInfo {
     # JobOwner Initial fields
     $JobOwnerInitFields = $Instance.GetDefaultInitFields([Microsoft.SqlServer.Management.Smo.Agent.Job])
 
+    # Invalid JobOwner Initial fields
+    $InvalidJobOwnerInitFields = $Instance.GetDefaultInitFields([Microsoft.SqlServer.Management.Smo.Agent.Job])
+
     # Database Initial Fields
     $DatabaseInitFields = $Instance.GetDefaultInitFields([Microsoft.SqlServer.Management.Smo.Database])
 
@@ -205,7 +208,22 @@ function Get-AllAgentInfo {
                 }
             }
         }
-        'InValidJobOwner' {
+        'InvalidJobOwner' {
+            $InvalidJobOwnerInitFields.Add("OwnerLoginName") | Out-Null # so we can check Job Owner
+            $InvalidJobOwnerInitFields.Add("Name") | Out-Null # so we can check Job Name
+            $Instance.SetDefaultInitFields([Microsoft.SqlServer.Management.Smo.Agent.Job], $InvalidJobOwnerInitFields)
+            $InvalidJobOwnerInitFields = $Instance.GetDefaultInitFields([Microsoft.SqlServer.Management.Smo.Agent.Job])
+
+            $ConfigValues | Add-Member -MemberType NoteProperty -Name 'InvalidJobOwner' -Value (Get-DbcConfigValue agent.invalidjobowner.name)
+
+            $InvalidJobOwner = $Instance.JobServer.Jobs.ForEach{
+                [PSCustomObject]@{
+                    InstanceName          = $Instance.Name
+                    JobName               = $PSItem.Name
+                    ExpectedJobOwnerName  = $ConfigValues.InvalidJobOwner
+                    ActualJobOwnerName    = $PSItem.OwnerLoginName
+                }
+            }
 
         }
         'AgentAlert' {
@@ -238,6 +256,7 @@ function Get-AllAgentInfo {
         DatabaseMailProfile = @($databaseMailProfile)
         AgentMailProfile    = @($agentMailProfile)
         JobOwner            = $JobOwner
+        InvalidJobOwner     = $InvalidJobOwner
     }
     return $testInstanceObject
 }