Update AppVeyor image

[andreasjordan]

This will probably fail as it's the first try and I can not test this locally.

But let's try to update the AppVeyor image to "Visual Studio 2022" to have SQL Server 2017 and 2019.

[andreasjordan]

Now too many tests are still in the default senario. I can fix this by moving more tests to SINGLE or MULTIPLE, which is the plan anyway.

But before I do this: @potatoqualitee - Do we want to move to the new image and versions 2017 and 2019?

[andreasjordan]

Old output in AppVeyor:

[andreasjordan]

This is the new version:

There is only one yellow line left - I will take care of that later. So this way it is very easy to have a deeper look at the test run.

[niphlod]

not sure LESS lines by default is the correct direction. Nobody looks at the logs, the important bit is the result of the checks.
when things go awry, you need all the log you can get, and easily.

[andreasjordan]

We missed a lot of bugs because tests were green and nobody looked at all the warnings in the AppVeyor output. In my local tests, I capture all the warnings and fail my tests if the output contains warnings. So I would like to have a clean and readable output with green and cyan and only yellow if its important.
I mainly suppressed the info messages from install-dbatools-library.ps1 by adding a silent switch.

But anyway: We sure can discuss if all my changes go to in the right direction. And as always: We can pick only some of the changes.

I can not get this branch to pass all tests, because I would need to change some tests to go into the correct scenario. But if I change tests, only those tests run and you cannot tell if the changes to the infrastructure work.

So I will stop here and we can discuss the changes while I open another branch to move some more tests to the new scenarios.

[niphlod]

we kinda are saying the same things. Log doesn't matter, the only thing that matters is the test results. IMHO a verbose(r) log helps to identify root causes better than a slim(mer) one.
Tests failing and not making the actual "result" of the test fail is a problem of the test itself, not the runner and not the log.... right ?